Implemented seek() and tell() for r/o streams of 'http'.
[gnome-vfs-httpcaptive.git] / modules / http-method.c
index 0c4d49e..cba1274 100644 (file)
@@ -100,6 +100,9 @@ http_debug_printf (char *fmt, ...)
 /* Standard HTTP proxy port */
 #define DEFAULT_HTTP_PROXY_PORT 8080
 
+/* Maximum amount of data to read if seek()ed forward. Otherwise make a new connection. */
+#define MAX_BUFFER_SEEK_SKIP_READ      0x10000
+
 /* GConf paths and keys */
 #define PATH_GCONF_GNOME_VFS "/system/http_proxy"
 #define ITEM_GCONF_HTTP_PROXY_PORT "port"
@@ -211,8 +214,11 @@ typedef struct {
        /* File info for this file */
        GnomeVFSFileInfo *file_info;
 
-       /* Bytes read so far.  */
-       GnomeVFSFileSize bytes_read;
+       /* File offset of current pointer of 'socket_buffer'. */
+       GnomeVFSFileOffset socket_buffer_offset;
+
+       /* Offset; Current file position. */
+       GnomeVFSFileOffset offset;
 
        /* Bytes to be written... */
        GByteArray *to_be_written;
@@ -283,25 +289,24 @@ defaults_file_info_new (void)
        return ret;
 }
 
-static HttpFileHandle *
-http_file_handle_new (GnomeVFSSocketBuffer *socket_buffer,
+/* Does not allocate the 'handle' memory. */
+static void
+http_file_handle_new (HttpFileHandle *handle,
+                     GnomeVFSSocketBuffer *socket_buffer,
                      GnomeVFSURI *uri)
 {
-       HttpFileHandle *result;
-
-       result = g_new0 (HttpFileHandle, 1);
-
-       result->socket_buffer = socket_buffer;
-       result->uri_string = gnome_vfs_uri_to_string (uri, GNOME_VFS_URI_HIDE_NONE );
-       result->uri = uri;
-       gnome_vfs_uri_ref(result->uri);
+       memset (handle, 0, sizeof (*handle));
 
-       result->file_info = defaults_file_info_new();
-       result->file_info->name = gnome_vfs_uri_extract_short_name (uri);
+       handle->socket_buffer = socket_buffer;
+       handle->uri_string = gnome_vfs_uri_to_string (uri, GNOME_VFS_URI_HIDE_NONE );
+       handle->uri = uri;
+       gnome_vfs_uri_ref(handle->uri);
 
-       return result;
+       handle->file_info = defaults_file_info_new();
+       handle->file_info->name = gnome_vfs_uri_extract_short_name (uri);
 }
 
+/* Does not free the 'handle' memory. */
 static void
 http_file_handle_destroy (HttpFileHandle *handle)
 {
@@ -321,8 +326,6 @@ http_file_handle_destroy (HttpFileHandle *handle)
 
        g_list_foreach(handle->files, (GFunc)gnome_vfs_file_info_unref, NULL);
        g_list_free(handle->files);
-
-       g_free (handle);
 }
 
 /* The following comes from GNU Wget with minor changes by myself.
@@ -652,15 +655,15 @@ static GnomeVFSResult
 create_handle (GnomeVFSURI *uri,
               GnomeVFSSocketBuffer *socket_buffer,
               GnomeVFSContext *context,
-              /* OUT */ HttpFileHandle **p_handle)
+              /* OUT */ HttpFileHandle *handle)
 {
        GString *header_string;
        GnomeVFSResult result;
        guint server_status;
 
-       g_return_val_if_fail (p_handle != NULL, GNOME_VFS_ERROR_INTERNAL);
+       g_return_val_if_fail (handle != NULL, GNOME_VFS_ERROR_INTERNAL);
 
-       *p_handle = http_file_handle_new (socket_buffer, uri);
+       http_file_handle_new (handle, socket_buffer, uri);
 
        header_string = g_string_new (NULL);
 
@@ -678,7 +681,7 @@ create_handle (GnomeVFSURI *uri,
                goto error;
        }
 
-       (*p_handle)->server_status = server_status;
+       handle->server_status = server_status;
 
        ANALYZE_HTTP ("==> +create_handle: fetching headers");
 
@@ -694,7 +697,7 @@ create_handle (GnomeVFSURI *uri,
                        break;
                }
 
-               (*p_handle)->response_headers = g_list_prepend ((*p_handle)->response_headers, 
+               handle->response_headers = g_list_prepend (handle->response_headers, 
                                                        g_strdup (header_string->str));
 
                /* We don't really care if we successfully parse the
@@ -704,10 +707,10 @@ create_handle (GnomeVFSURI *uri,
                 * past we would return NOT_FOUND if any header could
                 * not be parsed, but that seems wrong.
                 */
-               parse_header (*p_handle, header_string->str);
+               parse_header (handle, header_string->str);
        }
 
-       invoke_callback_headers_received (*p_handle);
+       invoke_callback_headers_received (handle);
 
        ANALYZE_HTTP ("==> -create_handle: fetching headers");
 
@@ -1499,7 +1502,7 @@ error:
 }
 
 static GnomeVFSResult
-make_request (HttpFileHandle **handle_return,
+make_request (HttpFileHandle *handle,
              GnomeVFSURI *uri,
              const gchar *method,
              GByteArray *data,
@@ -1514,8 +1517,7 @@ make_request (HttpFileHandle **handle_return,
        char *authn_header_request;
        char *authn_header_proxy;
 
-       g_return_val_if_fail (handle_return != NULL, GNOME_VFS_ERROR_INTERNAL);
-       *handle_return = NULL;
+       g_return_val_if_fail (handle != NULL, GNOME_VFS_ERROR_INTERNAL);
 
        ANALYZE_HTTP ("==> +make_request");
 
@@ -1593,33 +1595,33 @@ make_request (HttpFileHandle **handle_return,
                }
 
                /* Read the headers and create our internal HTTP file handle.  */
-               result = create_handle (uri, socket_buffer, context, handle_return);
+               result = create_handle (uri, socket_buffer, context, handle);
 
                if (result == GNOME_VFS_OK) {
                        socket_buffer = NULL;
                        break;
                }
-               if ((*handle_return)->server_status == HTTP_STATUS_UNAUTHORIZED) {
-                       if (! check_authn_retry_request (*handle_return, AuthnHeader_WWW, authn_header_request)) {
+               if (handle->server_status == HTTP_STATUS_UNAUTHORIZED) {
+                       if (! check_authn_retry_request (handle, AuthnHeader_WWW, authn_header_request)) {
                                break;
                        }
-               } else if ((*handle_return)->server_status == HTTP_STATUS_PROXY_AUTH_REQUIRED) {
-                       if (! check_authn_retry_request (*handle_return, AuthnHeader_WWW, authn_header_proxy)) {
+               } else if (handle->server_status == HTTP_STATUS_PROXY_AUTH_REQUIRED) {
+                       if (! check_authn_retry_request (handle, AuthnHeader_WWW, authn_header_proxy)) {
                                break;
                        }
                } else {
                        break;
                }
-               http_file_handle_destroy (*handle_return);
-               *handle_return = NULL;
+               http_file_handle_destroy (handle);
+               handle = NULL;
        }
 
        g_free (authn_header_request);
        g_free (authn_header_proxy);
 
-       if (result != GNOME_VFS_OK && *handle_return != NULL) {
-               http_file_handle_destroy (*handle_return);
-               *handle_return = NULL;
+       if (result != GNOME_VFS_OK && handle != NULL) {
+               http_file_handle_destroy (handle);
+               handle = NULL;
        }
 
        if (request != NULL) {
@@ -1654,10 +1656,6 @@ http_handle_close (HttpFileHandle *handle,
        ANALYZE_HTTP ("==> -http_handle_close");
 }
 
-typedef struct {
-       HttpFileHandle *http_file_handle;
-       } GnomeVFSHttpMethodHandle;
-
 static GnomeVFSResult
 do_open (GnomeVFSMethod *method,
         GnomeVFSMethodHandle **method_handle,
@@ -1666,7 +1664,6 @@ do_open (GnomeVFSMethod *method,
         GnomeVFSContext *context)
 {
        HttpFileHandle *handle;
-       GnomeVFSHttpMethodHandle *http_method_handle;
        GnomeVFSResult result = GNOME_VFS_OK;
        
        g_return_val_if_fail (uri->parent == NULL, GNOME_VFS_ERROR_INVALID_URI);
@@ -1677,17 +1674,16 @@ do_open (GnomeVFSMethod *method,
        ANALYZE_HTTP ("==> +do_open");
        DEBUG_HTTP (("+Open URI: '%s' mode:'%c'", gnome_vfs_uri_to_string(uri, 0), 
                     mode & GNOME_VFS_OPEN_READ ? 'R' : 'W'));
-       
+
+       handle = g_new (HttpFileHandle, 1);
        if (mode & GNOME_VFS_OPEN_READ) {
-               result = make_request (&handle, uri, "GET", NULL, NULL,
+               result = make_request (handle, uri, "GET", NULL, NULL,
                                       context);
        } else {
-               handle = http_file_handle_new(NULL, uri); /* shrug */
+               http_file_handle_new(handle, NULL, uri); /* shrug */
        }
        if (result == GNOME_VFS_OK) {
-               http_method_handle = g_new (GnomeVFSHttpMethodHandle, 1);
-               http_method_handle->http_file_handle = handle;
-               *method_handle = (GnomeVFSMethodHandle *) http_method_handle;
+               *method_handle = (GnomeVFSMethodHandle *) handle;
        } else {
                *method_handle = NULL;
        }
@@ -1729,9 +1725,11 @@ do_create (GnomeVFSMethod *method,
                
                ANALYZE_HTTP ("==> Checking to see if file exists");
                
-               result = make_request (&handle, uri, "HEAD", NULL, NULL,
+               handle = g_new (HttpFileHandle, 1);
+               result = make_request (handle, uri, "HEAD", NULL, NULL,
                                       context);
                http_handle_close (handle, context);
+               g_free (handle);
                
                if (result != GNOME_VFS_OK &&
                    result != GNOME_VFS_ERROR_NOT_FOUND) {
@@ -1744,8 +1742,10 @@ do_create (GnomeVFSMethod *method,
        
        ANALYZE_HTTP ("==> Creating initial file");
        
-       result = make_request (&handle, uri, "PUT", bytes, NULL, context);
+       handle = g_new (HttpFileHandle, 1);
+       result = make_request (handle, uri, "PUT", bytes, NULL, context);
        http_handle_close(handle, context);
+       g_free (handle);
        
        if (result != GNOME_VFS_OK) {
                /* the PUT failed */
@@ -1782,7 +1782,6 @@ do_close (GnomeVFSMethod *method,
          GnomeVFSMethodHandle *method_handle,
          GnomeVFSContext *context)
 {
-       GnomeVFSHttpMethodHandle *http_method_handle;
        HttpFileHandle *old_handle;
        HttpFileHandle *new_handle;
        GnomeVFSResult result;
@@ -1790,10 +1789,8 @@ do_close (GnomeVFSMethod *method,
        ANALYZE_HTTP ("==> +do_close");
        DEBUG_HTTP (("+Close handle:0x%08x", (unsigned int)method_handle));
 
-       http_method_handle = (GnomeVFSHttpMethodHandle *) method_handle;
-       old_handle = http_method_handle->http_file_handle;
-       g_free (http_method_handle);
-
+       old_handle = (HttpFileHandle *) method_handle;
+       
        /* if the handle was opened in write mode then:
         * 1) there won't be a connection open, and
         * 2) there will be data to_be_written...
@@ -1825,15 +1822,18 @@ do_close (GnomeVFSMethod *method,
                http_cache_invalidate_uri (uri);
 
                ANALYZE_HTTP ("==> doing PUT");
-               result = make_request (&new_handle, uri, "PUT", bytes, 
+               new_handle = g_new (HttpFileHandle, 1);
+               result = make_request (new_handle, uri, "PUT", bytes, 
                                       extraheader, context);
                g_free (extraheader);
                http_handle_close (new_handle, context);
+               g_free (new_handle);
        } else {
                result = GNOME_VFS_OK;
        }
-       
+
        http_handle_close (old_handle, context);
+       g_free (old_handle);
        
        DEBUG_HTTP (("-Close (%d)", result));
        ANALYZE_HTTP ("==> -do_close");
@@ -1846,20 +1846,23 @@ do_write (GnomeVFSMethod *method,
          GnomeVFSMethodHandle *method_handle,
          gconstpointer buffer,
          GnomeVFSFileSize num_bytes,
-         GnomeVFSFileSize *bytes_read,
+         GnomeVFSFileSize *bytes_written,
          GnomeVFSContext *context)
 {
        HttpFileHandle *handle;
 
        DEBUG_HTTP (("+Write handle:0x%08x", (unsigned int)method_handle));
 
-       handle = ((GnomeVFSHttpMethodHandle *) method_handle)->http_file_handle;
+       handle = (HttpFileHandle *) method_handle;
+
+       if (handle->offset != 0)
+               return GNOME_VFS_ERROR_NOT_SUPPORTED;
 
        if(handle->to_be_written == NULL) {
                handle->to_be_written = g_byte_array_new();
        }
        handle->to_be_written = g_byte_array_append(handle->to_be_written, buffer, num_bytes);
-       *bytes_read = num_bytes;
+       *bytes_written = num_bytes;
        
        DEBUG_HTTP (("-Write (0)"));
        
@@ -1881,15 +1884,55 @@ do_read (GnomeVFSMethod *method,
        ANALYZE_HTTP ("==> +do_read");
        DEBUG_HTTP (("+Read handle=0x%08x", (unsigned int) method_handle));
 
-       handle = ((GnomeVFSHttpMethodHandle *) method_handle)->http_file_handle;
+       handle = (HttpFileHandle *) method_handle;
 
        if (handle->file_info->flags & GNOME_VFS_FILE_INFO_FIELDS_SIZE) {
                GnomeVFSFileSize max_bytes;
 
-               max_bytes = handle->file_info->size - handle->bytes_read;
+               max_bytes = MAX (0, handle->file_info->size - handle->offset);
                num_bytes = MIN (max_bytes, num_bytes);
        }
 
+       if (!num_bytes) {
+               *bytes_read = 0;
+               return GNOME_VFS_OK;
+       }
+
+       if (1
+           && handle->offset >  handle->socket_buffer_offset
+           && handle->offset <= handle->socket_buffer_offset+MAX_BUFFER_SEEK_SKIP_READ) {
+static char drop_buffer[0x1000];
+GnomeVFSFileSize bytes, bytes_read;
+GnomeVFSResult result;
+
+               while ((bytes=MIN(sizeof(drop_buffer), handle->offset - handle->socket_buffer_offset))) {
+                       result = gnome_vfs_socket_buffer_read (handle->socket_buffer, drop_buffer, 
+                                       bytes, &bytes_read);
+                       if (result != GNOME_VFS_OK)
+                               return result;
+                       handle->socket_buffer_offset += bytes_read;
+               }
+       }
+
+       if (handle->offset != handle->socket_buffer_offset) {
+               GnomeVFSURI *uri = handle->uri;
+               gchar *extra_headers;
+
+               gnome_vfs_uri_ref(uri);
+               http_handle_close (handle, context);
+               extra_headers = g_strdup_printf("Range: bytes=%" G_GINT64_FORMAT "-\r\n",(gint64)handle->offset);
+               result = make_request (handle, uri, "GET", NULL, extra_headers,
+                                      context);
+               g_free (extra_headers);
+               gnome_vfs_uri_unref(uri);
+               if (result != GNOME_VFS_OK) {
+                       /* FIXME: 'method_handle' is now broken! */
+                       memset(handle, 0, sizeof (*handle));
+                       return result;
+               }
+               handle->socket_buffer_offset = handle->offset;
+       }
+
        result = gnome_vfs_socket_buffer_read (handle->socket_buffer, buffer, 
                        num_bytes, bytes_read);
        
@@ -1897,7 +1940,8 @@ do_read (GnomeVFSMethod *method,
                return GNOME_VFS_ERROR_EOF;
        }                                      
 
-       handle->bytes_read += *bytes_read;
+       handle->socket_buffer_offset += *bytes_read;
+       handle->offset += *bytes_read;
 
        DEBUG_HTTP (("-Read (%d)", result));
        ANALYZE_HTTP ("==> -do_read");
@@ -1905,6 +1949,53 @@ do_read (GnomeVFSMethod *method,
        return result;
 }
 
+static GnomeVFSResult
+do_seek (GnomeVFSMethod *method,
+        GnomeVFSMethodHandle *method_handle,
+        GnomeVFSSeekPosition  whence,
+        GnomeVFSFileOffset    offset,
+        GnomeVFSContext *context)
+{
+       HttpFileHandle *handle;
+
+       handle = (HttpFileHandle *) method_handle;
+
+       if (handle->to_be_written != NULL)
+               return GNOME_VFS_ERROR_NOT_SUPPORTED;
+
+       switch (whence) {
+       case GNOME_VFS_SEEK_START:
+               handle->offset = offset;
+               break;
+       case GNOME_VFS_SEEK_CURRENT:
+               handle->offset += offset;
+               break;
+       case GNOME_VFS_SEEK_END:
+               if (!(handle->file_info->flags & GNOME_VFS_FILE_INFO_FIELDS_SIZE))
+                       return GNOME_VFS_ERROR_NOT_SUPPORTED;
+               handle->offset = handle->file_info->size + offset;
+               break;
+       default:
+               g_return_val_if_reached(GNOME_VFS_ERROR_NOT_SUPPORTED);
+       }
+
+       return GNOME_VFS_OK;
+}
+
+static GnomeVFSResult
+do_tell (GnomeVFSMethod *method,
+        GnomeVFSMethodHandle *method_handle,
+        GnomeVFSFileOffset *offset_return)
+{
+       HttpFileHandle *handle;
+
+       handle = (HttpFileHandle *) method_handle;
+
+       *offset_return = handle->offset;
+
+       return GNOME_VFS_OK;
+}
+
 /* Directory handling - WebDAV servers only */
 
 static void
@@ -2160,7 +2251,7 @@ process_propfind_response(xmlNodePtr n,
 
 
 static GnomeVFSResult
-make_propfind_request (HttpFileHandle **handle_return,
+make_propfind_request (HttpFileHandle *handle,
        GnomeVFSURI *uri,
        gint depth,
        GnomeVFSContext *context)
@@ -2197,7 +2288,7 @@ make_propfind_request (HttpFileHandle **handle_return,
                http_cache_invalidate_uri_and_children (uri);
        }
 
-       result = make_request (handle_return, uri, "PROPFIND", request, 
+       result = make_request (handle, uri, "PROPFIND", request, 
                               extraheaders, context);
        
        /* FIXME bugzilla.gnome.org 43834: It looks like some http
@@ -2206,21 +2297,16 @@ make_propfind_request (HttpFileHandle **handle_return,
         * redirects or any other legal response. This case probably
         * needs to be made more robust.
         */
-       if (result == GNOME_VFS_OK && (*handle_return)->server_status != 207) { /* Multi-Status */
-               DEBUG_HTTP (("HTTP server returned an invalid PROPFIND response: %d", (*handle_return)->server_status));
+       if (result == GNOME_VFS_OK && handle->server_status != 207) { /* Multi-Status */
+               DEBUG_HTTP (("HTTP server returned an invalid PROPFIND response: %d", handle->server_status));
                result = GNOME_VFS_ERROR_NOT_SUPPORTED;
        }
        
        if (result == GNOME_VFS_OK) {
                do {
-                       GnomeVFSHttpMethodHandle *http_method_handle;
-
-                       http_method_handle = g_new (GnomeVFSHttpMethodHandle, 1);
-                       http_method_handle->http_file_handle = *handle_return;
-                       result = do_read (NULL, (GnomeVFSMethodHandle *) http_method_handle,
+                       result = do_read (NULL, (GnomeVFSMethodHandle *) handle,
                                          buffer, num_bytes, &bytes_read, context);
-                       g_free (http_method_handle);
-
+                       
                        if (result != GNOME_VFS_OK ) {
                                break;
                        }
@@ -2272,15 +2358,15 @@ make_propfind_request (HttpFileHandle **handle_return,
                                process_propfind_response (cur->xmlChildrenNode, uri);
                        
                        if (file_info->name != NULL) { 
-                               (*handle_return)->files = g_list_append ((*handle_return)->files, file_info);
+                               handle->files = g_list_append (handle->files, file_info);
                        } else {
                                /* This response refers to the root node */
                                /* Abandon the old information that came from create_handle*/
                                
-                               file_info->name = (*handle_return)->file_info->name;
-                               (*handle_return)->file_info->name = NULL;
-                               gnome_vfs_file_info_unref ((*handle_return)->file_info);
-                               (*handle_return)->file_info = file_info;
+                               file_info->name = handle->file_info->name;
+                               handle->file_info->name = NULL;
+                               gnome_vfs_file_info_unref (handle->file_info);
+                               handle->file_info = file_info;
                                found_root_node_props = TRUE;
                        }
                        
@@ -2304,9 +2390,9 @@ make_propfind_request (HttpFileHandle **handle_return,
         */
        
        if (depth == 0) {
-               http_cache_add_uri (uri, (*handle_return)->file_info, TRUE);
+               http_cache_add_uri (uri, handle->file_info, TRUE);
        } else {
-               http_cache_add_uri_and_children (uri, (*handle_return)->file_info, (*handle_return)->files);
+               http_cache_add_uri_and_children (uri, handle->file_info, handle->files);
        }
 
 cleanup:
@@ -2315,8 +2401,8 @@ cleanup:
        xmlFreeParserCtxt(parserContext);
        
        if (result != GNOME_VFS_OK) {
-               http_handle_close (*handle_return, context);
-               *handle_return = NULL;
+               http_handle_close (handle, context);
+               g_free (handle);
        }
        
        ANALYZE_HTTP ("==> -make_propfind_request");
@@ -2336,7 +2422,6 @@ do_open_directory(GnomeVFSMethod *method,
        HttpFileHandle *handle = NULL;
        GnomeVFSFileInfo * file_info_cached;
        GList *child_file_info_cached_list = NULL;
-       GnomeVFSHttpMethodHandle *http_method_handle;
 
        ANALYZE_HTTP ("==> +do_open_directory");
        DEBUG_HTTP (("+Open_Directory options: %d URI: '%s'", options, gnome_vfs_uri_to_string (uri, 0)));
@@ -2363,13 +2448,15 @@ do_open_directory(GnomeVFSMethod *method,
        file_info_cached = http_cache_check_directory_uri (uri, &child_file_info_cached_list);
 
        if (file_info_cached) {
-               handle = http_file_handle_new (NULL, uri);
+               handle = g_new (HttpFileHandle, 1);
+               http_file_handle_new (handle, NULL, uri);
                gnome_vfs_file_info_unref (handle->file_info);
                handle->file_info = file_info_cached;
                handle->files = child_file_info_cached_list;
                result = GNOME_VFS_OK;
        } else {
-               result = make_propfind_request(&handle, uri, 1, context);
+               handle = g_new (HttpFileHandle, 1);
+               result = make_propfind_request(handle, uri, 1, context);
                /* mfleming -- is this necessary?  Most DAV server's I've seen don't have the horrible
                 * lack-of-trailing-/-is-a-301 problem for PROPFIND's
                 */
@@ -2387,14 +2474,12 @@ do_open_directory(GnomeVFSMethod *method,
                    && handle->file_info->type != GNOME_VFS_FILE_TYPE_DIRECTORY) {
                        result = GNOME_VFS_ERROR_NOT_A_DIRECTORY;
                        http_handle_close (handle, context);
+                       g_free (handle);
                        handle = NULL;
                }
        }
-
-       http_method_handle = g_new (GnomeVFSHttpMethodHandle, 1);
-       http_method_handle->http_file_handle = handle;
-
-       *method_handle = (GnomeVFSMethodHandle *)http_method_handle;
+       
+       *method_handle = (GnomeVFSMethodHandle *)handle;
 
 error:
        DEBUG_HTTP (("-Open_Directory (%d) handle:0x%08x", result, (unsigned int)handle));
@@ -2409,15 +2494,13 @@ do_close_directory (GnomeVFSMethod *method,
                    GnomeVFSContext *context) 
 {
        HttpFileHandle *handle;
-       GnomeVFSHttpMethodHandle *http_method_handle;
        
        DEBUG_HTTP (("+Close_Directory"));
-
-       http_method_handle = (GnomeVFSHttpMethodHandle *) method_handle;
-       handle = http_method_handle->http_file_handle;
-       g_free (http_method_handle);
-
+       
+       handle = (HttpFileHandle *) method_handle;
+       
        http_handle_close(handle, context);
+       g_free (handle);
 
        DEBUG_HTTP (("-Close_Directory (0) handle:0x%08x", (unsigned int) method_handle));
 
@@ -2435,7 +2518,7 @@ do_read_directory (GnomeVFSMethod *method,
 
        DEBUG_HTTP (("+Read_Directory handle:0x%08x", (unsigned int) method_handle));
 
-       handle = ((GnomeVFSHttpMethodHandle *) method_handle)->http_file_handle;
+       handle = (HttpFileHandle *) method_handle;
        
        if (handle->files && g_list_length (handle->files)) {
                GnomeVFSFileInfo *original_info = g_list_nth_data (handle->files, 0);
@@ -2492,7 +2575,8 @@ do_get_file_info (GnomeVFSMethod *method,
                 * Start off by making a PROPFIND request.  Fall back to a HEAD if it fails
                 */
                
-               result = make_propfind_request (&handle, uri, 0, context);
+               handle = g_new (HttpFileHandle, 1);
+               result = make_propfind_request (handle, uri, 0, context);
                
                /* Note that theoretically we could not bother with this request if we get a 404 back,
                 * but since some servers seem to return wierd things on PROPFIND (mostly 200 OK's...)
@@ -2501,6 +2585,7 @@ do_get_file_info (GnomeVFSMethod *method,
                if (result == GNOME_VFS_OK) {
                        gnome_vfs_file_info_copy (file_info, handle->file_info);
                        http_handle_close (handle, context);
+                       g_free (handle);
                        handle = NULL;
                } else {
                        g_assert (handle == NULL); /* Make sure we're not leaking some old one */
@@ -2515,11 +2600,13 @@ do_get_file_info (GnomeVFSMethod *method,
 
                                ANALYZE_HTTP ("==> do_get_file_info: do GET ");
 
-                               result = make_request (&handle, uri, "GET", NULL, NULL, context);
+                               handle = g_new (HttpFileHandle, 1);
+                               result = make_request (handle, uri, "GET", NULL, NULL, context);
                                if (result == GNOME_VFS_OK) {
                                        gnome_vfs_file_info_copy (file_info, handle->file_info);
                                        http_cache_add_uri (uri, handle->file_info, FALSE);
                                        http_handle_close (handle, context);
+                                       g_free (handle);
                                }
 
                                /* If we get a redirect, we should be
@@ -2573,8 +2660,8 @@ do_get_file_info_from_handle (GnomeVFSMethod *method,
        
        DEBUG_HTTP (("+Get_File_Info_From_Handle"));
        
-       handle = ((GnomeVFSHttpMethodHandle *) method_handle)->http_file_handle;
-
+       handle = (HttpFileHandle *) method_handle;
+       
        gnome_vfs_file_info_copy (file_info, handle->file_info);
        
        DEBUG_HTTP (("-Get_File_Info_From_Handle"));
@@ -2611,7 +2698,8 @@ do_make_directory (GnomeVFSMethod *method,
         * So we do a PROPFIND first to find out
         */
        /* FIXME check cache here */
-       result = make_propfind_request(&handle, uri, 0, context);
+       handle = g_new (HttpFileHandle, 1);
+       result = make_propfind_request(handle, uri, 0, context);
 
        if (result == GNOME_VFS_OK) {
                result = GNOME_VFS_ERROR_FILE_EXISTS;
@@ -2621,10 +2709,12 @@ do_make_directory (GnomeVFSMethod *method,
                
                if (result == GNOME_VFS_ERROR_NOT_FOUND) {
                        http_cache_invalidate_uri_parent (uri);
-                       result = make_request (&handle, uri, "MKCOL", NULL, NULL, context);
+                       handle = g_new (HttpFileHandle, 1);
+                       result = make_request (handle, uri, "MKCOL", NULL, NULL, context);
                }
        }
        http_handle_close (handle, context);
+       g_free (handle);
        
        if (result == GNOME_VFS_ERROR_NOT_FOUND) {
                result = resolve_409 (method, uri, context);
@@ -2653,9 +2743,11 @@ do_remove_directory(GnomeVFSMethod *method,
        /* FIXME this should return GNOME_VFS_ERROR_DIRECTORY_NOT_EMPTY if the
         * directory is not empty
         */
-       result = make_request (&handle, uri, "DELETE", NULL, NULL,
+       handle = g_new (HttpFileHandle, 1);
+       result = make_request (handle, uri, "DELETE", NULL, NULL,
                               context);
        http_handle_close (handle, context);
+       g_free (handle);
        
        DEBUG_HTTP (("-Remove_Directory (%d)", result));
        ANALYZE_HTTP ("==> -do_remove_directory");
@@ -2705,8 +2797,10 @@ do_move (GnomeVFSMethod *method,
        destpath = gnome_vfs_uri_to_string (new_uri, GNOME_VFS_URI_HIDE_USER_NAME|GNOME_VFS_URI_HIDE_PASSWORD);
        destheader = g_strdup_printf ("Destination: %s\r\nOverwrite: %c\r\n", destpath, force_replace ? 'T' : 'F' );
 
-       result = make_request (&handle, old_uri, "MOVE", NULL, destheader, context);
+       handle = g_new (HttpFileHandle, 1);
+       result = make_request (handle, old_uri, "MOVE", NULL, destheader, context);
        http_handle_close (handle, context);
+       g_free (handle);
        handle = NULL;
 
        if (result == GNOME_VFS_ERROR_NOT_FOUND) {
@@ -2791,8 +2885,8 @@ static GnomeVFSMethod method = {
        do_close,
        do_read,
        do_write,
-       NULL, /* seek */
-       NULL, /* tell */
+       do_seek,
+       do_tell,
        NULL, /* truncate_handle */
        do_open_directory,
        do_close_directory,