lldb.git
5 days agoMerge branch 'addmainunit4-altlink-sharedstmt-dieref-dwz3-inlinebug-testcategory... dwz
Jan Kratochvil [Fri, 9 Apr 2021 20:57:45 +0000 (22:57 +0200)]
Merge branch 'addmainunit4-altlink-sharedstmt-dieref-dwz3-inlinebug-testcategory-testcase' into addmainunit4-altlink-sharedstmt-dieref-dwz3-inlinebug-testcategory-testcase-symlink

5 days agoMerge branch 'addmainunit4-altlink-sharedstmt-dieref-dwz3-inlinebug-testcategory...
Jan Kratochvil [Fri, 9 Apr 2021 20:57:40 +0000 (22:57 +0200)]
Merge branch 'addmainunit4-altlink-sharedstmt-dieref-dwz3-inlinebug-testcategory' into addmainunit4-altlink-sharedstmt-dieref-dwz3-inlinebug-testcategory-testcase

5 days agoMerge branch 'addmainunit4-altlink-sharedstmt-dieref-dwz3-inlinebug' into addmainunit...
Jan Kratochvil [Fri, 9 Apr 2021 20:57:35 +0000 (22:57 +0200)]
Merge branch 'addmainunit4-altlink-sharedstmt-dieref-dwz3-inlinebug' into addmainunit4-altlink-sharedstmt-dieref-dwz3-inlinebug-testcategory

5 days agoMerge branch 'addmainunit4-altlink-sharedstmt-dieref-dwz3' into addmainunit4-altlink...
Jan Kratochvil [Fri, 9 Apr 2021 20:57:30 +0000 (22:57 +0200)]
Merge branch 'addmainunit4-altlink-sharedstmt-dieref-dwz3' into addmainunit4-altlink-sharedstmt-dieref-dwz3-inlinebug

5 days agoMerge branch 'addmainunit4-altlink-sharedstmt-dieref' into addmainunit4-altlink-share...
Jan Kratochvil [Fri, 9 Apr 2021 20:57:25 +0000 (22:57 +0200)]
Merge branch 'addmainunit4-altlink-sharedstmt-dieref' into addmainunit4-altlink-sharedstmt-dieref-dwz3

5 days agoMerge branch 'addmainunit4-altlink-sharedstmt' into addmainunit4-altlink-sharedstmt...
Jan Kratochvil [Fri, 9 Apr 2021 20:57:20 +0000 (22:57 +0200)]
Merge branch 'addmainunit4-altlink-sharedstmt' into addmainunit4-altlink-sharedstmt-dieref

5 days agoMerge branch 'addmainunit4-altlink' into addmainunit4-altlink-sharedstmt
Jan Kratochvil [Fri, 9 Apr 2021 20:57:15 +0000 (22:57 +0200)]
Merge branch 'addmainunit4-altlink' into addmainunit4-altlink-sharedstmt

5 days agoMerge branch 'addmainunit4' into addmainunit4-altlink
Jan Kratochvil [Fri, 9 Apr 2021 20:57:10 +0000 (22:57 +0200)]
Merge branch 'addmainunit4' into addmainunit4-altlink

5 days agoMerge remote-tracking branch 'origin/main' into addmainunit4
Jan Kratochvil [Fri, 9 Apr 2021 20:57:05 +0000 (22:57 +0200)]
Merge remote-tracking branch 'origin/main' into addmainunit4

5 days agoRevert "[PowerPC] Add ROP Protection Instructions for PowerPC"
Mitch Phillips [Fri, 9 Apr 2021 20:32:12 +0000 (13:32 -0700)]
Revert "[PowerPC] Add ROP Protection Instructions for PowerPC"

This reverts commit 16fe741c69429235210c03c46420f8fa6aece4a1.

Reason: Broke the UBSan buildbots. More information available in the
phabricator review: https://reviews.llvm.org/D99375

5 days ago[mlir] NFC - Add help functions to scf.ForOp
Nicolas Vasilache [Fri, 9 Apr 2021 10:37:44 +0000 (10:37 +0000)]
[mlir] NFC - Add help functions to scf.ForOp

This revision adds 2 helperr functions that help tie OpOperands and
BlockArguments in scf.ForOp without having to use the internal implementation
details.

5 days ago[OpenMP51][DOCS] Claimed masked construct and report current patch, NFC.
cchen [Fri, 9 Apr 2021 20:21:13 +0000 (15:21 -0500)]
[OpenMP51][DOCS] Claimed masked construct and report current patch, NFC.

5 days ago[AMDGPU] Remove MachineDCE after SIFoldOperands
Jay Foad [Thu, 8 Apr 2021 16:10:54 +0000 (17:10 +0100)]
[AMDGPU] Remove MachineDCE after SIFoldOperands

Remove the MachineDCE pass after the first SIFoldOperands pass now
that SIFoldOperands deletes its own dead instructions.

Differential Revision: https://reviews.llvm.org/D100189

5 days ago[AMDGPU] SIFoldOperands: eagerly erase dead REG_SEQUENCEs
Jay Foad [Fri, 9 Apr 2021 12:52:35 +0000 (13:52 +0100)]
[AMDGPU] SIFoldOperands: eagerly erase dead REG_SEQUENCEs

This is fairly cheap to implement and means less work for future
passes like MachineDCE.

Differential Revision: https://reviews.llvm.org/D100188

5 days ago[MSSA] Rename uses in IDF regardless of new def position in basic block.
Alina Sbirlea [Fri, 9 Apr 2021 06:56:34 +0000 (23:56 -0700)]
[MSSA] Rename uses in IDF regardless of new def position in basic block.

When inserting a new def and renaming of uses is asked, always compute
IDF and do the renaming for the blocks with Phis in that IDF.
Resolves PR49859.

Differential Revision: https://reviews.llvm.org/D100163

5 days ago[libc++] NFC: Move unused include of <limits> to allocator_traits.h
Louis Dionne [Fri, 9 Apr 2021 19:19:42 +0000 (15:19 -0400)]
[libc++] NFC: Move unused include of <limits> to allocator_traits.h

The include should have been moved when I split allocator_traits.h out
of memory.

5 days ago[AMDGPU] Added udot2 op_sel test. NFC.
Stanislav Mekhanoshin [Fri, 9 Apr 2021 19:19:42 +0000 (12:19 -0700)]
[AMDGPU] Added udot2 op_sel test. NFC.

5 days agoAdd correct types to the xxsplti32dx pattern.
Stefan Pintilie [Fri, 9 Apr 2021 19:07:13 +0000 (14:07 -0500)]
Add correct types to the xxsplti32dx pattern.

Regiser types for xxsplti32dx for two td file patterns was incorrect.
Fixed the two types and added a test case that was reduced from a larger
failing test.

Reviewed By: nemanjai, #powerpc

Differential Revision: https://reviews.llvm.org/D100223

5 days ago[LLDB][NFC] Add clarifying comments for AddCXXSummary and AddCXXSynthetic
Shafik Yaghmour [Fri, 9 Apr 2021 19:05:36 +0000 (12:05 -0700)]
[LLDB][NFC] Add clarifying comments for AddCXXSummary and AddCXXSynthetic

Adding comments to AddCXXSynthetic and AddCXXSummary to better explain what they are doing.

5 days ago[OpenMP51] Initial support for masked directive and filter clause
cchen [Fri, 9 Apr 2021 19:00:36 +0000 (14:00 -0500)]
[OpenMP51] Initial support for masked directive and filter clause

Adds basic parsing/sema/serialization support for the #pragma omp masked
directive.

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D99995

5 days agoSupport: Remove code duplication for mapped_file_region accessors, NFC
Duncan P. N. Exon Smith [Fri, 9 Apr 2021 18:48:40 +0000 (11:48 -0700)]
Support: Remove code duplication for mapped_file_region accessors, NFC

5 days ago[libcxx] [test] Add more tests for renaming directories in fs.op.rename
Martin Storsjö [Tue, 23 Mar 2021 12:33:11 +0000 (14:33 +0200)]
[libcxx] [test] Add more tests for renaming directories in fs.op.rename

This was requested during the review of D98640.

Differential Revision: https://reviews.llvm.org/D99982

5 days ago[libcxx] [test] Use GetWindowsInaccessibleDir() in a couple more tests
Martin Storsjö [Thu, 11 Mar 2021 13:01:58 +0000 (15:01 +0200)]
[libcxx] [test] Use GetWindowsInaccessibleDir() in a couple more tests

Differential Revision: https://reviews.llvm.org/D98443

5 days ago[libcxx] [test] Use GetWindowsInaccessibleDir() instead of dirs with perms::none...
Martin Storsjö [Thu, 11 Mar 2021 19:42:13 +0000 (21:42 +0200)]
[libcxx] [test] Use GetWindowsInaccessibleDir() instead of dirs with perms::none in fs.op.is_*

Differential Revision: https://reviews.llvm.org/D98442

5 days ago[WebAssembly] Add shuffles as an option for lowering BUILD_VECTOR
Thomas Lively [Fri, 9 Apr 2021 18:21:49 +0000 (11:21 -0700)]
[WebAssembly] Add shuffles as an option for lowering BUILD_VECTOR

When lowering a BUILD_VECTOR SDNode, we choose among various possible vector
creation instructions in an attempt to minimize the total number of instructions
used. We previously considered using swizzles, consts, and splats, and this
patch adds shuffles as well. A common pattern that now lowers to shuffles is
when two 64-bit vectors are concatenated. Previously, concatenations generally
lowered to sequences of extract_lane and replace_lane instructions when they
could have been a single shuffle.

Differential Revision: https://reviews.llvm.org/D100018

5 days agoHandle alloc_size attribute on function pointers
Alex Richardson [Thu, 6 Dec 2018 12:22:08 +0000 (12:22 +0000)]
Handle alloc_size attribute on function pointers

I have been trying to statically find and analyze all calls to heap
allocation functions to determine how many of them use sizes known at
compile time vs only at runtime. While doing so I saw that quite a few
projects use replaceable function pointers for heap allocation and noticed
that clang was not able to annotate functions pointers with alloc_size.
I have changed the Sema checks to allow alloc_size on all function pointers
and typedefs for function pointers now and added checks that these
attributes are propagated to the LLVM IR correctly.

With this patch we can also compute __builtin_object_size() for calls to
allocation function pointers with the alloc_size attribute.

Reviewed By: aaron.ballman, erik.pilkington
Differential Revision: https://reviews.llvm.org/D55212

5 days ago[builtins] Avoid enum name conflicts with fenv.h
Alex Richardson [Fri, 9 Apr 2021 15:58:58 +0000 (16:58 +0100)]
[builtins] Avoid enum name conflicts with fenv.h

After a follow-up change (D98332) this header can be included the same time
as fenv.h when running the tests. To avoid enum members conflicting with
the macros/enums defined in the host fenv.h, prefix them with CRT_.

Reviewed By: peter.smith

Differential Revision: https://reviews.llvm.org/D98333

5 days ago[TableGen] Report an error message on a missing comma
Alex Richardson [Fri, 9 Apr 2021 15:58:16 +0000 (16:58 +0100)]
[TableGen] Report an error message on a missing comma

I recently forgot a comma in a defm argument list and tablegen just
failed with exit code 1 without printing an error message. I believe
this issue was introduced in a9fc44c5573208859c2550382755098d750fc47d.

This change prints the following instead:
.../clang/include/clang/Driver/Options.td:569:3: error: Expected comma before next argument

Reviewed By: Paul-C-Anagnostopoulos

Differential Revision: https://reviews.llvm.org/D100178

5 days ago[AArch64][GlobalISel] Fix incorrect codegen for <16 x s8> G_ASHR.
Amara Emerson [Fri, 9 Apr 2021 17:39:59 +0000 (10:39 -0700)]
[AArch64][GlobalISel] Fix incorrect codegen for <16 x s8> G_ASHR.

Fixes PR49904

5 days ago[PowerPC] Add ROP Protection Instructions for PowerPC
Stefan Pintilie [Fri, 9 Apr 2021 17:05:52 +0000 (12:05 -0500)]
[PowerPC] Add ROP Protection Instructions for PowerPC

There are four new PowerPC instructions that are introduced in
Power 10. They are hashst, hashchk, hashstp, hashchkp.

These instructions will be used for ROP Protection.
This patch adds the four instructions.

Reviewed By: nemanjai, amyk, #powerpc

Differential Revision: https://reviews.llvm.org/D99375

5 days ago[RGT] Disable some tests on Windows at compile-time, not runtime
Paul Robinson [Fri, 9 Apr 2021 16:40:00 +0000 (09:40 -0700)]
[RGT] Disable some tests on Windows at compile-time, not runtime

These show up as un-executed on non-Windows hosts.

Found by the Rotten Green Tests project.

5 days agoUpdate the linkage name of coro-split functions in the debug info.
Adrian Prantl [Fri, 9 Apr 2021 16:48:33 +0000 (09:48 -0700)]
Update the linkage name of coro-split functions in the debug info.

This patch updates the linkage name in the DISubprogram of coro-split
functions, which is particularly important for Swift, where the
funclets have a special name mangling. This patch does not affect C++
coroutines, since the DW_AT_specification is expected to hold the
(original) linkage name. I believe this is mostly due to limitations
in AsmPrinter, so we might be able to relax this restriction in the
future.

Differential Revision: https://reviews.llvm.org/D99693

5 days ago[PhaseOrdering] add test for llvm.expect; NFC
Sanjay Patel [Fri, 9 Apr 2021 15:52:47 +0000 (11:52 -0400)]
[PhaseOrdering] add test for llvm.expect; NFC

5 days ago[Flang] Changes to mangling code
Eric Schweitz [Mon, 5 Apr 2021 16:09:10 +0000 (17:09 +0100)]
[Flang] Changes to mangling code

Call static functions using the class name (fir::NameUniquer).
Add function for mangling derivedTypes.

All the name mangling functions that are ultimately called are
tested in unittests/Optimizer/InternalNamesTest.cpp.

Differential Revision: https://reviews.llvm.org/D99967

5 days ago[InstCombine] Regenerate 2010-11-23-Distributed.ll tests
Simon Pilgrim [Fri, 9 Apr 2021 15:38:57 +0000 (16:38 +0100)]
[InstCombine] Regenerate 2010-11-23-Distributed.ll tests

5 days ago[clang] tests: cleanup, update and add some new ones
Matheus Izvekov [Tue, 23 Mar 2021 20:20:07 +0000 (21:20 +0100)]
[clang] tests: cleanup, update and add some new ones

This reworks a small set of tests, as preparatory work for implementing
P2266.
* Run for more standard versions, including c++2b.
* Normalize file names and run commands.
* Adds some extra tests.

New Coroutine tests taken from Aaron Puchert's D68845.

Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>
Reviewed By: thakis

Differential Revision: https://reviews.llvm.org/D99225

5 days ago[X86] Fold cmpeq/ne(or(X,Y),X) --> cmpeq/ne(and(~X,Y),0) on non-BMI targets (PR44136)
Simon Pilgrim [Fri, 9 Apr 2021 15:10:57 +0000 (16:10 +0100)]
[X86] Fold cmpeq/ne(or(X,Y),X) --> cmpeq/ne(and(~X,Y),0) on non-BMI targets (PR44136)

Followup to D100177, enable the fold for non-BMI targets as well.

5 days ago[RGT] Tweak test so assertion is always executed
Paul Robinson [Fri, 9 Apr 2021 15:03:44 +0000 (08:03 -0700)]
[RGT] Tweak test so assertion is always executed

Any given Windows system will have only one "system" encoding for
UTF-16 (BE or LE), so the assert for the other one would always
show up as rotten.  Use a common assertion for both paths to avoid
this.

5 days ago[MLIR][Shape] Combine `cstr_eq` only if they share shape operands
Frederik Gossen [Fri, 9 Apr 2021 14:51:34 +0000 (16:51 +0200)]
[MLIR][Shape] Combine `cstr_eq` only if they share shape operands

Differential Revision: https://reviews.llvm.org/D100198

5 days ago[X86][BMI] Fold cmpeq/ne(or(X,Y),X) --> cmpeq/ne(and(~X,Y),0) (PR44136)
Simon Pilgrim [Fri, 9 Apr 2021 14:51:53 +0000 (15:51 +0100)]
[X86][BMI] Fold cmpeq/ne(or(X,Y),X) --> cmpeq/ne(and(~X,Y),0) (PR44136)

I've initially just enabled this for BMI which has the ANDN instruction for i32/i64 - the i16/i8 cases give an idea of what'd we get when we enable it in all cases (I'll do this as a later commit).

Additionally, the i16/i8 cases could be freely promoted to i32 (as the args are already zeroext) and we could then make use of ANDN + the free cmp0 there as well - this has come up in PR48768 and PR49028 so I'm going to look at this soon.

https://alive2.llvm.org/ce/z/QVWHP_
https://alive2.llvm.org/ce/z/pLngT-

Vector cases do not appear to benefit from this as we end up with having to generate the zero vector as well - this is one of the reasons I didn't try to tie this into hasAndNot/hasAndNotCompare.

Differential Revision: https://reviews.llvm.org/D100177

5 days ago[libc++] Fix abs and div overload issue for compilers on AIX
jasonliu [Thu, 8 Apr 2021 21:48:42 +0000 (21:48 +0000)]
[libc++] Fix abs and div overload issue for compilers on AIX

Summary:
AIX system's stdlib.h provide different overload of abs and div
depending on compiler versions.

For example, std::div(long, long) and std::abs(long) are not available
from OS's stdlib.h when building with clang, but they are available
when building with xlclang compiler.

Therefore, we need to provide those extra overloads in libc++'s stdlib.h
when OS's stdlib.h does not.

Differential Revision: https://reviews.llvm.org/D99767

5 days ago[HIP] Workaround ICE compiling SemaChecking.cpp with gcc 5
Yaxun (Sam) Liu [Fri, 9 Apr 2021 14:39:23 +0000 (10:39 -0400)]
[HIP] Workaround ICE compiling SemaChecking.cpp with gcc 5

Change-Id: I6c6213bc6b90365bfb78636ce7fb0700a58807cf

5 days ago[InstCombine] try to eliminate an instruction in min/max -> abs fold
Sanjay Patel [Fri, 9 Apr 2021 13:58:16 +0000 (09:58 -0400)]
[InstCombine] try to eliminate an instruction in min/max -> abs fold

As suggested in the review thread for 5094e12 and seen in the
motivating example from https://llvm.org/PR49885, it's not
clear if we have a way to create the optimal code without
this heuristic.

5 days ago[InstCombine] add test with multiple uses of min/max negated operand; NFC
Sanjay Patel [Fri, 9 Apr 2021 13:47:00 +0000 (09:47 -0400)]
[InstCombine] add test with multiple uses of min/max negated operand; NFC

5 days agoRISCVABIInfo::classifyArgumentType: Fix static analyzer warnings with uninitialized...
Soumi Manna [Fri, 9 Apr 2021 14:23:32 +0000 (15:23 +0100)]
RISCVABIInfo::classifyArgumentType: Fix static analyzer warnings with uninitialized variables warnings - NFCI

Differential Revision: https://reviews.llvm.org/D100172

5 days ago[X86] Add zeroext attributes to i8/i16 and/or/xor overflow tests
Simon Pilgrim [Fri, 9 Apr 2021 14:00:56 +0000 (15:00 +0100)]
[X86] Add zeroext attributes to i8/i16 and/or/xor overflow tests

Matches original c/c++ test cases

5 days ago[clangd] Log a message when gRPC support is off, but remote-index is configured
Kadir Cetinkaya [Thu, 8 Apr 2021 13:37:32 +0000 (15:37 +0200)]
[clangd] Log a message when gRPC support is off, but remote-index is configured

Before this change clangd would emit a diagnostic whenever remote-index
was configured but binary didn't have grpc support.

This can be annoying when projects are configuring remote-index through their
configs but developers have a clangd binary without the support.

Differential Revision: https://reviews.llvm.org/D100103

5 days ago[TableGen] [docs] Change title of tblgen.rst to fix man page filename
Paul C. Anagnostopoulos [Fri, 9 Apr 2021 13:35:52 +0000 (09:35 -0400)]
[TableGen] [docs] Change title of tblgen.rst to fix man page filename

5 days ago[AMDGPU] Allow relaxed/consume memory order for atomic inc/dec
Yaxun (Sam) Liu [Thu, 8 Apr 2021 21:44:29 +0000 (17:44 -0400)]
[AMDGPU] Allow relaxed/consume memory order for atomic inc/dec

Reviewed by: Jon Chesterfield

Differential Revision: https://reviews.llvm.org/D100144

5 days agoFor non-null pointer checks, do not descend through out-of-bounds GEPs
Momchil Velikov [Fri, 9 Apr 2021 12:54:39 +0000 (13:54 +0100)]
For non-null pointer checks, do not descend through out-of-bounds GEPs

In LazyValueInfoImpl::isNonNullAtEndOfBlock we populate a set of
pointers, known to be non-null at the end of a block (e.g. because we
did a load through them). We then infer that any pointer, based on an
element of this set is non-null as well ("based" here meaning a
non-null pointer is the underlying object). This is incorrect, even if
the base pointer was non-null, the value of a GEP, that lacks the
inbounds` attribute, may be null.

This issue appeared as miscompilation of the following test case:

int puts(const char *);

typedef struct iter {
  int *val;
} iter_t;

static long distance(iter_t first, iter_t last) {
  long r = 0;
  for (; first.val != last.val; first.val++)
    ++r;
  return r;
}

int main() {
  int arr[2] = {0};
  iter_t i, j;
  i.val = arr;
  j.val = arr + 1;
  if (distance(i, j) >= 2)
    puts("failed");
  else
    puts("passed");
}

This fixes PR49662.

Differential Revision: https://reviews.llvm.org/D99642

5 days ago[AMDGPU] SIFoldOperands: eagerly delete dead copies
Jay Foad [Thu, 8 Apr 2021 15:07:49 +0000 (16:07 +0100)]
[AMDGPU] SIFoldOperands: eagerly delete dead copies

This is cheap to implement, means less work for future passes like
MachineDCE, and slightly improves the folding in some cases.

Differential Revision: https://reviews.llvm.org/D100117

5 days ago[X86] Adjust PR44136 tests to add cmpne coverage as well
Simon Pilgrim [Fri, 9 Apr 2021 12:42:18 +0000 (13:42 +0100)]
[X86] Adjust PR44136 tests to add cmpne coverage as well

Alive2: https://alive2.llvm.org/ce/z/pLngT-

5 days ago[clang] Tiny format fix
Nathan Sidwell [Thu, 8 Apr 2021 17:17:14 +0000 (10:17 -0700)]
[clang] Tiny format fix

Misindented close brace.

Differential Revision: https://reviews.llvm.org/D100129

5 days ago[PowerPC, test] Fix use of undef FileCheck var
Thomas Preud'homme [Mon, 5 Apr 2021 10:28:35 +0000 (11:28 +0100)]
[PowerPC, test] Fix use of undef FileCheck var

LLVM test CodeGen/PowerPC/ctrloops-softfloat.ll tries to check for the
absence of sequences of instructions with several CHECK-NOT with one of
those directives using a variable defined in another. However CHECK-NOT
are checked independently so that is using a variable defined in a
pattern that should not occur in the input.

This commit changes occurence of the variable for the regex used in its
definition, thereby making each CHECK-NOT independent.

Reviewed By: nemanjai

Differential Revision: https://reviews.llvm.org/D99881

5 days ago[PowerPC, test] Fix use of undef FileCheck var
Thomas Preud'homme [Sun, 4 Apr 2021 23:07:35 +0000 (00:07 +0100)]
[PowerPC, test] Fix use of undef FileCheck var

Commit 6ad3d05b681b36f6ecc98523257d154053e4116d disables the definition
of CSR that a follow-up CHECK-NOT directive depends on. This commit
replaces the undefined CSR variable use by the regex used to define it.

Reviewed By: nemanjai

Differential Revision: https://reviews.llvm.org/D99870

5 days ago[clangd] Add --check-lines to restrict --check to specific lines
Adam Czachorowski [Thu, 18 Mar 2021 20:14:02 +0000 (21:14 +0100)]
[clangd] Add --check-lines to restrict --check to specific lines

This will allow us to add code completion, which is too expensive at
every token, to --check too.

Differential Revision: https://reviews.llvm.org/D98970

5 days ago[PowerPC, test] Fix use of undef FileCheck var
Thomas Preud'homme [Sun, 4 Apr 2021 22:58:18 +0000 (23:58 +0100)]
[PowerPC, test] Fix use of undef FileCheck var

Commit 6646033e6e759657b6122fde64844fd28a2c9635 removed the definition
of variable RESULT used in two CHECK-NOT directives in LLVM test
CodeGen/PowerPC/ppc64-i128-abi.ll. This commit replaces the uses by the
regex that was used to define that variable.

Reviewed By: nemanjai

Differential Revision: https://reviews.llvm.org/D99868

6 days ago[OpenCL] Simplify InsertOCLBuiltinDeclarationsFromTable
Sven van Haastregt [Fri, 9 Apr 2021 10:54:15 +0000 (11:54 +0100)]
[OpenCL] Simplify InsertOCLBuiltinDeclarationsFromTable

 - Use a range-based for loop.  This will help a later patch to skip
   prototypes that use an unavailable return type or argument type.

 - Replace a dyn_cast with a cast, as we are only dealing with
   FunctionProtoType Types here.

6 days ago[X86] Add PR44136 test coverage
Simon Pilgrim [Fri, 9 Apr 2021 10:31:29 +0000 (11:31 +0100)]
[X86] Add PR44136 test coverage

6 days ago[AMDGPU] Use SIInstrFlags for flat variants. NFC
Sebastian Neubauer [Tue, 30 Mar 2021 12:38:07 +0000 (14:38 +0200)]
[AMDGPU] Use SIInstrFlags for flat variants. NFC

Use SIInstrFlags to differentiate between the different
variants of flat instructions (flat, global and scratch).
This should make it easier to bundle the immediate offset logic in a
single place and implement restrictions and bug workarounds.

Fixed version of D99587, which does not rely on the address space.

Differential Revision: https://reviews.llvm.org/D99743

6 days ago[AA][NFC] Convert AliasResult to class containing offset for PartialAlias case.
dfukalov [Tue, 16 Mar 2021 13:36:17 +0000 (16:36 +0300)]
[AA][NFC] Convert AliasResult to class containing offset for PartialAlias case.

Add an ability to store `Offset` between partially aliased location. Use this
storage within returned `ResultAlias` instead of caching it in `AAQueryInfo`.

Reviewed By: asbirlea

Differential Revision: https://reviews.llvm.org/D98718

6 days ago[MLIR][Shape] Add convenience builder for `shape.assuming_all`
Frederik Gossen [Fri, 9 Apr 2021 10:13:10 +0000 (12:13 +0200)]
[MLIR][Shape] Add convenience builder for `shape.assuming_all`

Differential Revision: https://reviews.llvm.org/D100105

6 days ago[NFC][AA] Prepare to convert AliasResult to class with PartialAlias offset.
dfukalov [Fri, 5 Mar 2021 10:58:13 +0000 (13:58 +0300)]
[NFC][AA] Prepare to convert AliasResult to class with PartialAlias offset.

Main reason is preparation to transform AliasResult to class that contains
offset for PartialAlias case.

Reviewed By: asbirlea

Differential Revision: https://reviews.llvm.org/D98027

6 days ago[X86] combineHorizOpWithShuffle - peek through one use bitcasts when decoding shuffles.
Simon Pilgrim [Thu, 8 Apr 2021 13:49:31 +0000 (14:49 +0100)]
[X86] combineHorizOpWithShuffle - peek through one use bitcasts when decoding shuffles.

Checking for one use, peek through bitcasts of the horizop args to allows us to merge shuffles of different widths through the horizop.

6 days ago[MLIR][Shape] Canonicalize `assuming_all` when all operands are `cstr_eq` ops
Frederik Gossen [Fri, 9 Apr 2021 09:00:01 +0000 (11:00 +0200)]
[MLIR][Shape] Canonicalize `assuming_all` when all operands are `cstr_eq` ops

Differential Revision: https://reviews.llvm.org/D100104

6 days ago[FunctionAttrs] Force old pm in test so it doens't behave differently depending on...
Benjamin Kramer [Fri, 9 Apr 2021 09:46:19 +0000 (11:46 +0200)]
[FunctionAttrs] Force old pm in test so it doens't behave differently depending on the configuration setting for this flag

6 days ago[NFC] Move statictic increment out of helper
Max Kazantsev [Fri, 9 Apr 2021 09:32:01 +0000 (16:32 +0700)]
[NFC] Move statictic increment out of helper

6 days ago[RegisterScavenging] Add asserts for better errors
Sebastian Neubauer [Thu, 8 Apr 2021 14:27:46 +0000 (16:27 +0200)]
[RegisterScavenging] Add asserts for better errors

These cases were failing before, but with cryptic asserts.
Add asserts in the RegScavenger that fail earlier with better
messages. NFC

Differential Revision: https://reviews.llvm.org/D100109

6 days ago[AMDGPU] IsFlatScratch/Global -> FlatScratch/Global
Sebastian Neubauer [Fri, 9 Apr 2021 09:20:15 +0000 (11:20 +0200)]
[AMDGPU] IsFlatScratch/Global -> FlatScratch/Global

Remove 'Is' from IsFlatScratch/Global. NFC

Differential Revision: https://reviews.llvm.org/D100108

6 days ago[GVN][NFC] Factor out load elimination logic via PRE for reuse
Max Kazantsev [Fri, 9 Apr 2021 08:22:47 +0000 (15:22 +0700)]
[GVN][NFC] Factor out load elimination logic via PRE for reuse

6 days ago[MLIR] Do not yield values from an assuming op that are never used
Frederik Gossen [Thu, 8 Apr 2021 09:21:50 +0000 (11:21 +0200)]
[MLIR] Do not yield values from an assuming op that are never used

Differential Revision: https://reviews.llvm.org/D100042

6 days ago[RISCV][NFC] Replace explicit type i64 with riscv customized SDTypeProfile.
Jim Lin [Fri, 9 Apr 2021 09:01:48 +0000 (17:01 +0800)]
[RISCV][NFC] Replace explicit type i64 with riscv customized SDTypeProfile.

New SDTypeProfile can be reused for other word operation patterns without explicit i64 type in the future.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D100097

6 days ago[test, LoopVectorize] Fix use of var defined in CHECK-NOT
Thomas Preud'homme [Sun, 28 Mar 2021 00:03:37 +0000 (00:03 +0000)]
[test, LoopVectorize] Fix use of var defined in CHECK-NOT

LLVM test Transforms/LoopVectorize/pr34681.ll tries to check for the
absence of a sequence of instructions with several CHECK-NOT with one of
those directives using a variable defined in another. However CHECK-NOT
are checked independently so that is using a variable defined in a
pattern that should not occur in the input.

This commit only checks for the absence of icmp ne 1 which rules out the
presence of the whole sequence and does not involve an undefined
variable.

Reviewed By: fhahn

Differential Revision: https://reviews.llvm.org/D99582

6 days ago[lldb] Update object.test after 'nosync' inference was enabled.
Alexander Belyaev [Fri, 9 Apr 2021 08:02:24 +0000 (10:02 +0200)]
[lldb] Update object.test after 'nosync' inference was enabled.

https://reviews.llvm.org/D99769

6 days ago[lldb] Update UUID after https://reviews.llvm.org/D99978.
Alexander Belyaev [Fri, 9 Apr 2021 08:01:50 +0000 (10:01 +0200)]
[lldb] Update UUID after https://reviews.llvm.org/D99978.

6 days ago[NFC][PowerPC] add test cases for reverse memory op transformation
Chen Zheng [Fri, 9 Apr 2021 07:21:24 +0000 (03:21 -0400)]
[NFC][PowerPC] add test cases for reverse memory op transformation

6 days ago[RISCV][NFC] Fix formatting
Jim Lin [Fri, 9 Apr 2021 05:20:07 +0000 (13:20 +0800)]
[RISCV][NFC] Fix formatting

6 days ago[Test] Add two more tests on PRE with guards
Max Kazantsev [Fri, 9 Apr 2021 06:19:52 +0000 (13:19 +0700)]
[Test] Add two more tests on PRE with guards

6 days ago[GreedyRA ORE] Re-factor computeNumberOfSplillsReloads.
Serguei Katkov [Fri, 9 Apr 2021 04:29:35 +0000 (11:29 +0700)]
[GreedyRA ORE] Re-factor computeNumberOfSplillsReloads.

Replace if-else to if-continue usage.
This simplifies further extension of the collected stats.

6 days ago[mlir][Linalg] Drop unit-trip loops of reductions only if other reduction loops exists.
MaheshRavishankar [Fri, 9 Apr 2021 05:30:49 +0000 (22:30 -0700)]
[mlir][Linalg] Drop unit-trip loops of reductions only if other reduction loops exists.

Recent change enable dropping unit-trip loops of "reduction" iterator
type as well. This is fine as long as there is one other "reduction"
iterator in the operation. Without this the initialized value (value
of `out`) is not read which leads to a correctness issue.

Also fix a bug in the `fill` -> `tensor_reshape` folding. The `out`
operand of the `fill` needs to be reshaped to get the `out` operand of
the generated `fill` operation.

Differential Revision: https://reviews.llvm.org/D100145

6 days ago[libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types.
zoecarver [Fri, 9 Apr 2021 05:01:35 +0000 (22:01 -0700)]
[libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types.

Refs: https://bugs.llvm.org/show_bug.cgi?id=32147

Differential Revision: https://reviews.llvm.org/D80882

6 days ago[LICM] Hoist loads with invariant.group metadata
Arthur Eubanks [Fri, 2 Apr 2021 03:22:29 +0000 (20:22 -0700)]
[LICM] Hoist loads with invariant.group metadata

Previously loading the vtable used in calling a virtual method in a loop
was not hoisted out of the loop. This fixes that.

canSinkOrHoistInst() itself doesn't check that the load operands are
loop invariant, callers also check that separately.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D99784

6 days ago[debug-info][NFC] Set -mtriple to avoid the test failure under other targets.
Esme-Yi [Fri, 9 Apr 2021 04:53:59 +0000 (04:53 +0000)]
[debug-info][NFC] Set -mtriple to avoid the test failure under other targets.

6 days ago[RS4GC] Cleanup meetBDVState. NFC.
Serguei Katkov [Fri, 9 Apr 2021 03:20:25 +0000 (10:20 +0700)]
[RS4GC] Cleanup meetBDVState. NFC.

meetBDVState looks pretty difficult to read and follow.
This is purely NFC but doing several things:

1) Combine meet and meetBDVState
2) Move the function to be a member of BDVState
3) Make BDVState be a mutable object
4) Convert switch to sequence of ifs
5) Adds comments.

Reviewers: reames, dantrushin
Reviewed By: reames
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D99064

6 days ago[clang][SourceManager] Fix -Wparentheses warning (NFC)
Yang Fan [Fri, 9 Apr 2021 02:22:56 +0000 (10:22 +0800)]
[clang][SourceManager] Fix -Wparentheses warning (NFC)

GCC warning:
```
/llvm-project/clang/lib/Basic/SourceManager.cpp: In instantiation of ‘constexpr T likelyhasbetween(T, unsigned char, unsigned char) [with T = long unsigned int]’:
/llvm-project/clang/lib/Basic/SourceManager.cpp:1292:52:   required from here
/llvm-project/clang/lib/Basic/SourceManager.cpp:1264:48: warning: suggest parentheses around ‘+’ in operand of ‘&’ [-Wparentheses]
 1264 |           (x & ~static_cast<T>(0) / 255 * 127) +
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
 1265 |               (~static_cast<T>(0) / 255 * (127 - (m - 1)))) &
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

6 days ago[RISCV][NFC] Add explicit type i64 to RV64 only patterns.
Jim Lin [Fri, 9 Apr 2021 01:36:33 +0000 (09:36 +0800)]
[RISCV][NFC] Add explicit type i64 to RV64 only patterns.

Add explicit type i64 to RV64 only patterns to stop emitting unneeded i32 patterns.

It can reduce the isel table size.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D100089

6 days ago[lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order.
Alex Orlov [Fri, 9 Apr 2021 01:29:14 +0000 (05:29 +0400)]
[lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order.

This fixes https://bugs.llvm.org/show_bug.cgi?id=41712 bug.

Reviewed By: aganea

Differential Revision: https://reviews.llvm.org/D99978

6 days ago[mlir][tosa] Add tosa.max_pool2d lowering to linalg int max pooling additions
Rob Suderman [Thu, 1 Apr 2021 23:39:25 +0000 (16:39 -0700)]
[mlir][tosa] Add tosa.max_pool2d lowering to linalg int max pooling additions

Lowerings tosa.max_pool2d to linalg equivalent operations. Includes
adding max pooling operations for linalg, with corresponding tests.

Differential Revision: https://reviews.llvm.org/D99824

6 days agoADT: Sink the guts of StringMapEntry::Create into StringMapEntryBase
Duncan P. N. Exon Smith [Thu, 28 Jan 2021 23:43:04 +0000 (15:43 -0800)]
ADT: Sink the guts of StringMapEntry::Create into StringMapEntryBase

Sink the interesting parts of StringMapEntry::Create into a new function
StringMapEntryBase::allocateWithKey that's only templated on the
allocator, taking the entry size and alignment as parameters.

As dblaikie pointed out in the review, it'd be interesting as a
follow-up to make this more generic and maybe sink at least some of it
into a source file; I haven't done that yet myself, but I left behind an
encouraging comment.

Differential Revision: https://reviews.llvm.org/D95654

6 days agoDebugInfo: Include inline namespaces in template specialization parameter names
David Blaikie [Fri, 9 Apr 2021 00:36:41 +0000 (17:36 -0700)]
DebugInfo: Include inline namespaces in template specialization parameter names

This ensures these types have distinct names if they are distinct types
(eg: if one is an instantiation with a type in one inline namespace, and
another from a type with the same simple name, but in a different inline
namespace).

6 days agoUse default ref capture to avoid unused capture warning on assert-used variable
David Blaikie [Thu, 8 Apr 2021 23:56:27 +0000 (16:56 -0700)]
Use default ref capture to avoid unused capture warning on assert-used variable

6 days ago[mlir][spirv] Define spv.ImageDrefGather operation
Weiwei Li [Thu, 8 Apr 2021 23:22:25 +0000 (19:22 -0400)]
[mlir][spirv] Define spv.ImageDrefGather operation

This patch doesn't support the optional operands of ImageDrefGather. The support of optional operands will be implemented later.

co-authered-by: Alan Liu <alanliu.yf@gmail.com>

Differential Revision: https://reviews.llvm.org/D100128

6 days agoSupport: Use std::unique_ptr for SignpostEmitter::Impl, NFC, 3rd attempt
Duncan P. N. Exon Smith [Fri, 9 Apr 2021 00:00:43 +0000 (17:00 -0700)]
Support: Use std::unique_ptr for SignpostEmitter::Impl, NFC, 3rd attempt

This reverts commit e35afbe535f96086141f57a5ce7d679429b4405f, reapplying
022ccedde8877e877b45e49641544b5e4fff0b42 and
e7ed5c920db3f537a85d962c1c918a1bb6de99fd.

- The first attempt missed defining `SignpostEmitterImpl`.
- The second attempt missed defining `llvm::SignpostEmitterImpl`.

Not sure how I failed to test both versions locally before; I thought
I'd turned the feature off via rerunning `cmake` but it must have been
stuck in place. This time I confirmed via `clang -E` that I was testing
both build configurations.

Original commit message:

    Replace some manual memory management with std::unique_ptr.

    Differential Revision: https://reviews.llvm.org/D100151

6 days agoRevert "Revert "Revert "Support: Use std::unique_ptr for SignpostEmitter::Impl, NFC"""
Duncan P. N. Exon Smith [Thu, 8 Apr 2021 23:58:12 +0000 (16:58 -0700)]
Revert "Revert "Revert "Support: Use std::unique_ptr for SignpostEmitter::Impl, NFC"""

This reverts commit e7ed5c920db3f537a85d962c1c918a1bb6de99fd again, due
to more buildbot failures:
https://lab.llvm.org/buildbot/#/builders/131/builds/8191

6 days agoRevert "Revert "Support: Use std::unique_ptr for SignpostEmitter::Impl, NFC""
Duncan P. N. Exon Smith [Thu, 8 Apr 2021 23:41:40 +0000 (16:41 -0700)]
Revert "Revert "Support: Use std::unique_ptr for SignpostEmitter::Impl, NFC""

This reverts commit 078072285d3fbdaa94f9a91140eb5c1223b548af, reapplying
022ccedde8877e877b45e49641544b5e4fff0b42.

I figured out why this was failing in other environments: it's not a
problem with std::unique_ptr, but that SignpostEmitterImpl only has a
forward declaration. Adding an empty definition should do the trick.

Original commit message:

    Replace some manual memory management with std::unique_ptr.

    Differential Revision: https://reviews.llvm.org/D100151

6 days agoRevert "Support: Use std::unique_ptr for SignpostEmitter::Impl, NFC"
Duncan P. N. Exon Smith [Thu, 8 Apr 2021 23:36:42 +0000 (16:36 -0700)]
Revert "Support: Use std::unique_ptr for SignpostEmitter::Impl, NFC"

This reverts commit 022ccedde8877e877b45e49641544b5e4fff0b42. Looks like
some hosts need a definition of SignpostEmitterImpl to put it in a
unique_ptr:
https://lab.llvm.org/buildbot/#/builders/92/builds/7733

6 days agoSupport: Avoid unnecessary std::function for SignpostEmitterImpl::SignpostLog
Duncan P. N. Exon Smith [Thu, 8 Apr 2021 23:20:31 +0000 (16:20 -0700)]
Support: Avoid unnecessary std::function for SignpostEmitterImpl::SignpostLog

The destructor for SignPostEmitterImpl::SignpostLog is known statically. Avoid
the unnecessary vtable indirection through std::function in the std::unique_ptr
by turning LogDeleter into a struct. No real functionality change here.

Differential Revision: https://reviews.llvm.org/D100154

6 days agoSupport: Drop the no-op initializer for SignpostEmitterImpl::Signposts, NFC
Duncan P. N. Exon Smith [Thu, 8 Apr 2021 23:14:16 +0000 (16:14 -0700)]
Support: Drop the no-op initializer for SignpostEmitterImpl::Signposts, NFC

This is a DenseMap, which has its own initializer; we don't need to explicitly
call the default constructor here.

Differential Revision: https://reviews.llvm.org/D100152

6 days agoSupport: Use std::unique_ptr for SignpostEmitter::Impl, NFC
Duncan P. N. Exon Smith [Thu, 8 Apr 2021 23:04:55 +0000 (16:04 -0700)]
Support: Use std::unique_ptr for SignpostEmitter::Impl, NFC

Replace some manual memory management with std::unique_ptr.

Differential Revision: https://reviews.llvm.org/D100151

6 days agoSupport: Extract fs::resize_file_before_mapping_readwrite from FileOutputBuffer
Duncan P. N. Exon Smith [Wed, 27 Jan 2021 00:01:36 +0000 (16:01 -0800)]
Support: Extract fs::resize_file_before_mapping_readwrite from FileOutputBuffer

Add a variant of `fs::resize_file` for use immediately before opening a
file with `mapped_file_region::readwrite`. On Windows, `_chsize`
(`ftruncate`) is slow, but `CreateFileMapping` (`mmap`) automatically
extends the file so the call to `fs::resize_file` can be skipped.

This optimization was added to `FileOutputBuffer` in
da9bc2e56d5a5c6332a9def1a0065eb399182b93; this commit just extracts the
logic out and adds a unit test.

Differential Revision: https://reviews.llvm.org/D95490