-RtlCompareMemory(): reactos implementation is buggy (reason included)

diff --git a/ntoskrnl/rtl/mem.c b/ntoskrnl/rtl/mem.c
index e046b7f..eae3c94 100644 (file)
--- a/ntoskrnl/rtl/mem.c
+++ b/ntoskrnl/rtl/mem.c
@@ -63,8 +63,12 @@ MmCopyFromCaller(PVOID Dest, PVOID Src, ULONG NumberOfBytes)
     }
 }
 
-#endif /* LIBCAPTIVE */
 
+/* FIXME: It should return the length of initial sequence of matching characters,
+ * not the total amount of matching/differing bytes. We are not interested in
+ * the tail after the first non-matching byte.
+ * W32 doc formulation is a bit misleading.
+ */
 ULONG
 STDCALL
 RtlCompareMemory(PVOID Source1,
@@ -91,7 +95,6 @@ RtlCompareMemory(PVOID        Source1,
    return(total);
 }
 
-#ifndef LIBCAPTIVE
 
 ULONG
 STDCALL