Revert "[msan] Intercept qsort, qsort_r."
authorReid Kleckner <rnk@google.com>
Fri, 27 Dec 2019 19:24:07 +0000 (11:24 -0800)
committerReid Kleckner <rnk@google.com>
Fri, 27 Dec 2019 19:24:07 +0000 (11:24 -0800)
commit8fcce5ac73d49981656d9126e6c88391c1f6bf01
treeb48cab0fd76ca4ebc0447545ae1a0ef209447131
parent3213ce966b6b3395ba6a5f5d3ee7e17c7bd857ac
Revert "[msan] Intercept qsort, qsort_r."

This reverts commit 7a9ebe95125ea87a494d0c18f44f10bd70e12188, and
dependent commit 54c522420347e58aa7bae1892cf5c5672b57c875, which
disables qsort interception for some iOS platforms.

After this change, the -Nolibc sanitizer common test binary crashes on
startup on my regular Linux workstation, as well as on our bots:
https://ci.chromium.org/p/chromium/builders/try/linux_upload_clang/740

 ********************
  Failing Tests (1):
       SanitizerCommon-Unit ::
       ./Sanitizer-x86_64-Test/SanitizerCommon.NolibcMain

Loading it up in gdb shows that it crashes during relocation processing,
which suggests that some glibc loader versions do not support the
THREADLOCAL data added in this interceptor.
compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc
compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h
compiler-rt/test/msan/qsort.cpp [deleted file]