lldb.git
15 months ago[libc] Disable AOR ulp tests for sinf, cosf and sincosf.
Siva Chandra Reddy [Fri, 17 Apr 2020 15:59:35 +0000 (08:59 -0700)]
[libc] Disable AOR ulp tests for sinf, cosf and sincosf.

They seemed to fallback to the system libc and start depending on its
accuracy.

15 months ago[Support][X86] Include sched.h after D78324
Fangrui Song [Fri, 17 Apr 2020 15:43:02 +0000 (08:43 -0700)]
[Support][X86] Include sched.h after D78324

http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/28848/steps/build%20stage%201/logs/stdio

15 months ago[builtins] Add missing header in D77912 and make __builtin_clzll more robust
Fangrui Song [Fri, 17 Apr 2020 15:29:58 +0000 (08:29 -0700)]
[builtins] Add missing header in D77912 and make __builtin_clzll more robust

15 months ago[ELF] Support a few more SPARCv9 relocations
LemonBoy [Fri, 17 Apr 2020 14:58:15 +0000 (07:58 -0700)]
[ELF] Support a few more SPARCv9 relocations

Implemented a bunch of relocations found in binaries with medium/large code model and the Local-Exec TLS model. The binaries link and run fine in Qemu.
In addition, the emulation `elf64_sparc` is now recognized.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D77672

15 months ago[SYCL] Update __builtin_unique_stable_name for other backends.
Erich Keane [Fri, 17 Apr 2020 14:52:50 +0000 (07:52 -0700)]
[SYCL] Update __builtin_unique_stable_name for other backends.

The CUDA backend (and other downstreams) have trouble with the tilde and
arrow delimiter, so replace these with 'm' (for macro) and '_'.  Since
these are in the normal lambda ID location, the format of these should
not conflict with anything else.

15 months ago[Support][X86] Change getHostNumPhsicalCores() to return number of physical cores...
Fangrui Song [Thu, 16 Apr 2020 19:05:53 +0000 (12:05 -0700)]
[Support][X86] Change getHostNumPhsicalCores() to return number of physical cores enabled by affinity

Fixes https://bugs.llvm.org/show_bug.cgi?id=45556

While here, make the x86-64 code available for x86-32.

The output has been available and stable since
https://git.kernel.org/linus/3dd9d514846cdca1dcef2e4fce666d85e199e844 (2005)
```
processor:
...
physical id:
siblings:
core id:
```

Don't check HAVE_SCHED_GETAFFINITY/HAVE_CPU_COUNT. The interface is
simply available in every libc which can build LLVM.

Reviewed By: aganea

Differential Revision: https://reviews.llvm.org/D78324

15 months ago[GlobalISel][AMDGPU] add legalization for G_FREEZE
Dominik Montada [Tue, 14 Apr 2020 09:25:05 +0000 (11:25 +0200)]
[GlobalISel][AMDGPU] add legalization for G_FREEZE

Summary:
Copy the legalization rules from SelectionDAG:
-widenScalar using anyext
-narrowScalar using intermediate merges
-scalarize/fewerElements using unmerge
-moreElements using G_IMPLICIT_DEF and insert

Add G_FREEZE legalization actions to AMDGPULegalizerInfo.
Use the same legalization actions as G_IMPLICIT_DEF.

Depends on D77795.

Reviewers: dsanders, arsenm, aqjune, aditya_nandakumar, t.p.northover, lebedev.ri, paquette, aemerson

Reviewed By: arsenm

Subscribers: kzhuravl, yaxunl, dstuttard, tpr, t-tye, jvesely, nhaehnle, kerbowa, wdng, rovka, hiraditya, volkan, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78092

15 months ago[ValueLattice] Steal bits from Tag to track range extensions (NFC).
Florian Hahn [Fri, 17 Apr 2020 14:30:00 +0000 (15:30 +0100)]
[ValueLattice] Steal bits from Tag to track range extensions (NFC).

Users of ValueLatticeElement currently have to ensure constant ranges
are not extended indefinitely. For example, in SCCP, mergeIn goes to
overdefined if a constantrange value is repeatedly merged with larger
constantranges. This is a simple form of widening.

In some cases, this leads to an unnecessary loss of information and
things can be improved by allowing a small number of extensions in the
hope that a fixed point is reached after a small number of steps.

To make better decisions about widening, it is helpful to keep track of
the number of range extensions. That state is tied directly to a
concrete ValueLatticeElement and some unused bits in the class can be
used. The current patch preserves the existing behavior by default:
CheckWiden defaults to false and if CheckWiden is true, a single change
to the range is allowed.

Follow-up patches will slightly increase the threshold for widening.

Reviewers: efriedma, davide, mssimpso

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D78145

15 months ago[libc++] NFC: Rename Lit feature for no RTTI to -fno-rtti
Louis Dionne [Fri, 17 Apr 2020 14:36:32 +0000 (10:36 -0400)]
[libc++] NFC: Rename Lit feature for no RTTI to -fno-rtti

15 months agoRemove accidental include.
Benjamin Kramer [Fri, 17 Apr 2020 14:36:30 +0000 (16:36 +0200)]
Remove accidental include.

Thank you clangd.

15 months agoChange users of CreateShuffleVector to pass the masks as int instead of Constants
Benjamin Kramer [Fri, 17 Apr 2020 14:33:39 +0000 (16:33 +0200)]
Change users of CreateShuffleVector to pass the masks as int instead of Constants

No functionality change intended.

15 months ago[PhaseOrdering] remove blank lines in tests; NFC
Sanjay Patel [Fri, 17 Apr 2020 13:34:34 +0000 (09:34 -0400)]
[PhaseOrdering] remove blank lines in tests; NFC

15 months ago[AMDGPU] New helper functions to get a register class of a given width
Jay Foad [Thu, 9 Apr 2020 11:01:05 +0000 (12:01 +0100)]
[AMDGPU] New helper functions to get a register class of a given width

Summary:
Introduce new helper functions getVGPRClassForBitWidth,
getAGPRClassForBitWidth, getSGPRClassForBitWidth and use them to
refactor various other functions that all contained their own lists of
valid register class widths. NFC.

Reviewers: arsenm, rampitec

Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, kerbowa, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78311

15 months agoImplement _ExtInt as an extended int type specifier.
Erich Keane [Tue, 24 Dec 2019 15:28:40 +0000 (07:28 -0800)]
Implement _ExtInt as an extended int type specifier.

Introduction/Motivation:
LLVM-IR supports integers of non-power-of-2 bitwidth, in the iN syntax.
Integers of non-power-of-two aren't particularly interesting or useful
on most hardware, so much so that no language in Clang has been
motivated to expose it before.

However, in the case of FPGA hardware normal integer types where the
full bitwidth isn't used, is extremely wasteful and has severe
performance/space concerns.  Because of this, Intel has introduced this
functionality in the High Level Synthesis compiler[0]
under the name "Arbitrary Precision Integer" (ap_int for short). This
has been extremely useful and effective for our users, permitting them
to optimize their storage and operation space on an architecture where
both can be extremely expensive.

We are proposing upstreaming a more palatable version of this to the
community, in the form of this proposal and accompanying patch.  We are
proposing the syntax _ExtInt(N).  We intend to propose this to the WG14
committee[1], and the underscore-capital seems like the active direction
for a WG14 paper's acceptance.  An alternative that Richard Smith
suggested on the initial review was __int(N), however we believe that
is much less acceptable by WG14.  We considered _Int, however _Int is
used as an identifier in libstdc++ and there is no good way to fall
back to an identifier (since _Int(5) is indistinguishable from an
unnamed initializer of a template type named _Int).

[0]https://www.intel.com/content/www/us/en/software/programmable/quartus-prime/hls-compiler.html)
[1]http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2472.pdf

Differential Revision: https://reviews.llvm.org/D73967

15 months ago[libc++abi] NFC: Remove trailing whitespace
Louis Dionne [Fri, 17 Apr 2020 14:06:55 +0000 (10:06 -0400)]
[libc++abi] NFC: Remove trailing whitespace

15 months ago[XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary
jasonliu [Thu, 16 Apr 2020 19:52:34 +0000 (19:52 +0000)]
[XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary

Summary:
AIX symbol have qualname and unqualified name. The stock getSymbol
could only return unqualified name, which leads us to patch many
caller side(lowerConstant, getMCSymbolForTOCPseudoMO).
So we should try to address this problem in the callee
side(getSymbol) and clean up the caller side instead.

Note: this is a "mostly" NFC patch, with a fix for the original
lowerConstant behavior.

Differential Revision: https://reviews.llvm.org/D78045

15 months ago[AMDGPU] Simplify SIRegisterInfo::getRegSplitParts
Jay Foad [Fri, 17 Apr 2020 09:28:47 +0000 (10:28 +0100)]
[AMDGPU] Simplify SIRegisterInfo::getRegSplitParts

Summary:
Use more logic and fewer tables. This reduces the line count and
reduces the effort required to introduce more register classes of
different sizes in future.

Reviewers: arsenm, rampitec, nhaehnle

Subscribers: kzhuravl, jvesely, wdng, yaxunl, dstuttard, tpr, t-tye, hiraditya, kerbowa, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78351

15 months ago[VectorUtils] Create shufflevector masks as int vectors instead of Constants
Benjamin Kramer [Fri, 17 Apr 2020 13:28:00 +0000 (15:28 +0200)]
[VectorUtils] Create shufflevector masks as int vectors instead of Constants

No functionality change intended.

15 months ago[clang][AST] Support AST files larger than 512M
Dmitry Polukhin [Thu, 16 Apr 2020 16:24:46 +0000 (09:24 -0700)]
[clang][AST] Support AST files larger than 512M

Summary:
Clang uses 32-bit integers for storing bit offsets from the beginning of
the file that results in 512M limit on AST file. This diff replaces
absolute offsets with relative offsets from the beginning of
corresponding data structure when it is possible. And uses 64-bit
offsets for DeclOffests and TypeOffssts because these coder AST
section may easily exceeds 512M alone.

This diff breaks AST file format compatibility so VERSION_MAJOR bumped.

Test Plan:
Existing clang AST serialization tests
Tested on clangd with ~700M and ~900M preamble files
check-clang with ubsan

Reviewers: rsmith, dexonsmith

Subscribers: ilya-biryukov, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D76594

15 months ago[libc++] Move .fail.cpp tests with verify-support to .verify.cpp
Louis Dionne [Fri, 17 Apr 2020 12:47:40 +0000 (08:47 -0400)]
[libc++] Move .fail.cpp tests with verify-support to .verify.cpp

15 months ago[x86] rename variables for types for readability; NFC
Sanjay Patel [Fri, 17 Apr 2020 12:41:18 +0000 (08:41 -0400)]
[x86] rename variables for types for readability; NFC

This gets harder to follow if we allow changing types/sizes
between source, dest, and intermediate value.

15 months ago[x86] add/adjust tests for FP<->int casts; NFC
Sanjay Patel [Fri, 17 Apr 2020 12:22:17 +0000 (08:22 -0400)]
[x86] add/adjust tests for FP<->int casts; NFC

15 months ago[RISCV][AsmParser] Implement .option (no)pic
Roger Ferrer Ibanez [Fri, 17 Apr 2020 07:39:49 +0000 (07:39 +0000)]
[RISCV][AsmParser] Implement .option (no)pic

Differential Revision: https://reviews.llvm.org/D77867

15 months ago[clangd] Fix memory leak in FileIndexTest
Kadir Cetinkaya [Fri, 17 Apr 2020 11:56:22 +0000 (13:56 +0200)]
[clangd] Fix memory leak in FileIndexTest

15 months ago[clangd] Drop dangling relations while sharding
Kadir Cetinkaya [Fri, 17 Apr 2020 11:19:52 +0000 (13:19 +0200)]
[clangd] Drop dangling relations while sharding

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78359

15 months agoRecommit [X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitter(Part II)
Shengchen Kan [Fri, 17 Apr 2020 03:17:38 +0000 (11:17 +0800)]
Recommit [X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitter(Part II)

Previous patch didn't handle the early return in `emitREXPrefix` correctly,
which causes REX prefix was not emitted for instruction without
operands. This patch includes the fix for that.

15 months agoUnifyFunctionExitNodes.h - remove unnecessary PassRegistry.h include. NFC
Simon Pilgrim [Fri, 17 Apr 2020 11:14:02 +0000 (12:14 +0100)]
UnifyFunctionExitNodes.h - remove unnecessary PassRegistry.h include. NFC

15 months agoSSAUpdaterBulk.h - remove unnecessary SmallPtrSet.h include. NFC
Simon Pilgrim [Fri, 17 Apr 2020 11:01:25 +0000 (12:01 +0100)]
SSAUpdaterBulk.h - remove unnecessary SmallPtrSet.h include. NFC

15 months agoScalar.h - remove unused forward declarations. NFC.
Simon Pilgrim [Fri, 17 Apr 2020 10:49:13 +0000 (11:49 +0100)]
Scalar.h - remove unused forward declarations. NFC.

15 months agoAMDGPU/GlobalISel: Work around another selector crash
Jay Foad [Fri, 17 Apr 2020 10:49:38 +0000 (11:49 +0100)]
AMDGPU/GlobalISel: Work around another selector crash

This does for G_EXTRACT_VECTOR_ELT what 588bd7be366 did for G_TRUNC.

Ideally types without a corresponding register class wouldn't reach
here, but we're currently missing some (in particular a 192-bit class
is missing).

15 months ago[NFC] Add missing 'const' notion to LCSSA-related functions
Max Kazantsev [Fri, 17 Apr 2020 10:18:01 +0000 (17:18 +0700)]
[NFC] Add missing 'const' notion to LCSSA-related functions

These functions don't really do any changes to loop info or
dominator tree. We should state this explicitly using 'const'.

15 months agoProvide operand indices to adjustSchedDependency
Fraser Cormack [Tue, 31 Mar 2020 10:57:51 +0000 (11:57 +0100)]
Provide operand indices to adjustSchedDependency

This allows targets to know exactly which operands are contributing to
the dependency, which is required for targets with per-operand
scheduling models.

Differential Revision: https://reviews.llvm.org/D77135

15 months ago[cmake] LLVMVectorize - add include/llvm/Transforms/Vectorize header path
Simon Pilgrim [Fri, 17 Apr 2020 10:06:26 +0000 (11:06 +0100)]
[cmake] LLVMVectorize - add include/llvm/Transforms/Vectorize header path

MSVC projects were missing the llvm/Transforms/Vectorize/* headers

15 months agoMCObjectWriter.h - remove Endian.h/EndianStream.h/raw_ostream.h includes. NFC
Simon Pilgrim [Thu, 16 Apr 2020 18:31:45 +0000 (19:31 +0100)]
MCObjectWriter.h - remove Endian.h/EndianStream.h/raw_ostream.h includes. NFC

Push these includes down to the the writers that actually need them, a number of which were implicitly relying on the MCObjectWriter.h.

15 months agoConstantPools.h - remove unused DenseMap.h include. NFC.
Simon Pilgrim [Thu, 16 Apr 2020 17:25:44 +0000 (18:25 +0100)]
ConstantPools.h - remove unused DenseMap.h include. NFC.

15 months agoMCStreamer.h - remove unused llvm::MCCodePaddingContext forward declaration. NFC.
Simon Pilgrim [Thu, 16 Apr 2020 17:21:35 +0000 (18:21 +0100)]
MCStreamer.h - remove unused llvm::MCCodePaddingContext forward declaration. NFC.

15 months agoMCWasmStreamer.h.h - cleanup includes and forward declarations. NFC.
Simon Pilgrim [Thu, 16 Apr 2020 17:13:23 +0000 (18:13 +0100)]
MCWasmStreamer.h.h - cleanup includes and forward declarations. NFC.
Remove unnecessary SmallPtrSet.h/SectionKind.h includes
Remove unused MCAssembler/raw_ostream forward declarations

15 months agoMCSectionXCOFF.h - remove unnecessary Twine.h include. NFC
Simon Pilgrim [Thu, 16 Apr 2020 17:10:59 +0000 (18:10 +0100)]
MCSectionXCOFF.h - remove unnecessary Twine.h include. NFC

15 months ago[tools][tests] - Use --check-prefixes instead of multiple --check-prefix. NFCI.
Georgii Rymar [Wed, 15 Apr 2020 15:28:08 +0000 (18:28 +0300)]
[tools][tests] - Use --check-prefixes instead of multiple --check-prefix. NFCI.

There is no need to use `--check-prefix` multiple times.
It helps to improve readability/test maintainability.
This patch does it for all tools at once.

Differential revision: https://reviews.llvm.org/D78217

15 months ago[gn build] Port ff9379f4b2d
LLVM GN Syncbot [Fri, 17 Apr 2020 09:27:53 +0000 (09:27 +0000)]
[gn build] Port ff9379f4b2d

15 months ago[NFC] Remove waymarking because it improves performances
Tyker [Fri, 17 Apr 2020 08:53:01 +0000 (10:53 +0200)]
[NFC] Remove waymarking because it improves performances

Summary:
This patch remove waymarking and replaces it with storing a pointer to the User in the Use.
here are the results on the measurements for the CTMark tests of the test suite.
```
Metric: instructions_count

Program                                                      baseline      patched       diff
 test-suite :: CTMark/ClamAV/clamscan.test                    72557942065   71733653521  -1.1%
 test-suite :: CTMark/sqlite3/sqlite3.test                    76281422939   75484840636  -1.0%
 test-suite :: CTMark/consumer-typeset/consumer-typeset.test  51364676366   50862185614  -1.0%
 test-suite :: CTMark/SPASS/SPASS.test                        60476106505   59908437767  -0.9%
 test-suite :: CTMark/tramp3d-v4/tramp3d-v4.test              112578442329  111725050856 -0.8%
 test-suite :: CTMark/mafft/pairlocalalign.test               50846133013   50473644539  -0.7%
 test-suite :: CTMark/kimwitu++/kc.test                       54692641250   54349070299  -0.6%
 test-suite :: CTMark/7zip/7zip-benchmark.test                182216614747  181216091230 -0.5%
 test-suite :: CTMark/Bullet/bullet.test                      123459210616  122905866767 -0.4%
 Geomean difference                                                                      -0.8%

Metric: peak_memory_use

Program                                                      baseline  patched   diff
 test-suite :: CTMark/tramp3d-v4/tramp3d-v4.test              326864    338524    3.6%
 test-suite :: CTMark/sqlite3/sqlite3.test                    216412    221240    2.2%
 test-suite :: CTMark/7zip/7zip-benchmark.test                11808284  12022604  1.8%
 test-suite :: CTMark/Bullet/bullet.test                      6831752   6945988   1.7%
 test-suite :: CTMark/SPASS/SPASS.test                        2682552   2721820   1.5%
 test-suite :: CTMark/ClamAV/clamscan.test                    5037256   5107936   1.4%
 test-suite :: CTMark/consumer-typeset/consumer-typeset.test  2752728   2790768   1.4%
 test-suite :: CTMark/mafft/pairlocalalign.test               1517676   1537244   1.3%
 test-suite :: CTMark/kimwitu++/kc.test                       1090748   1103448   1.2%
 Geomean difference                                                               1.8%

Metric: compile_time

Program                                                      baseline patched diff
 test-suite :: CTMark/consumer-typeset/consumer-typeset.test  14.71    14.38  -2.2%
 test-suite :: CTMark/sqlite3/sqlite3.test                    23.18    22.73  -2.0%
 test-suite :: CTMark/7zip/7zip-benchmark.test                57.96    56.99  -1.7%
 test-suite :: CTMark/ClamAV/clamscan.test                    20.75    20.49  -1.2%
 test-suite :: CTMark/kimwitu++/kc.test                       18.35    18.15  -1.1%
 test-suite :: CTMark/SPASS/SPASS.test                        18.72    18.57  -0.8%
 test-suite :: CTMark/mafft/pairlocalalign.test               14.09    14.00  -0.6%
 test-suite :: CTMark/Bullet/bullet.test                      37.38    37.19  -0.5%
 test-suite :: CTMark/tramp3d-v4/tramp3d-v4.test              33.81    33.76  -0.2%
 Geomean difference                                                           -1.1%
```

i believe that it is worth trading +1.8% peak memory use for -1.1% compile time.
also this patch removes waymarking which simplifies the Use and User classes.

Reviewers: nikic, lattner

Reviewed By: lattner

Subscribers: russell.gallop, foad, ggreif, rriddle, ekatz, fhahn, lebedev.ri, mgorny, hiraditya, george.burgess.iv, asbirlea, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77144

15 months ago[CommandLine] Fix cl::ConsumeAfter support with more than one positional argument
Yi-Hong Lyu [Fri, 17 Apr 2020 06:45:45 +0000 (23:45 -0700)]
[CommandLine] Fix cl::ConsumeAfter support with more than one positional argument

Summary:
Currently, cl::ConsumeAfter only works for the case that has exactly one
positional argument. Without the fix, it skip fulfilling first positional
argument and put that additional positional argument in interpreter arguments.

Reviewers: bkramer, Mordante, rnk, lattner, beanz, craig.topper

Reviewed By: rnk

Subscribers: JosephTremoulet, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77242

15 months agoUse proper dependency name for libc.include.stdio
Alex Brachet [Fri, 17 Apr 2020 09:10:22 +0000 (05:10 -0400)]
Use proper dependency name for libc.include.stdio

15 months agoIPO.h - remove unused llvm::Function forward declaration. NFC.
Simon Pilgrim [Thu, 16 Apr 2020 20:44:50 +0000 (21:44 +0100)]
IPO.h - remove unused llvm::Function forward declaration. NFC.

15 months agoConstantFolding.h - remove unused llvm::ConstantVector forward declaration. NFC.
Simon Pilgrim [Thu, 16 Apr 2020 19:50:46 +0000 (20:50 +0100)]
ConstantFolding.h - remove unused llvm::ConstantVector forward declaration. NFC.

15 months agoScheduleDFS.h - Replace ArrayRef.h include with forward declaration. NFC.
Simon Pilgrim [Wed, 15 Apr 2020 21:32:17 +0000 (22:32 +0100)]
ScheduleDFS.h - Replace ArrayRef.h include with forward declaration. NFC.

We have no need to include the entire header.

15 months agoScoreboardHazardRecognizer.h - remove unnecessary llvm::InstrItineraryData forward...
Simon Pilgrim [Wed, 15 Apr 2020 21:30:21 +0000 (22:30 +0100)]
ScoreboardHazardRecognizer.h - remove unnecessary llvm::InstrItineraryData forward declaration. NFC.

We have to include MCInstrItineraries.h where its defined.

15 months ago[clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword
Matthias Gehre [Tue, 14 Apr 2020 18:17:22 +0000 (20:17 +0200)]
[clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword

Summary:
Before this PR, `modernize-use-using` would transform the typedef in
```

template <typename a> class TemplateKeyword {
  typedef typename a::template f<> e;
  typedef typename a::template f<>::d e2;
};
```
into
```
template <typename a> class TemplateKeyword {
  using d = typename a::b<>;
  using d2 = typename a::template a::b<>::c;
};
```
The first one is missing the `template` keyword,
the second one has an extra `a::` scope. Both result
in compilation errors.

Reviewers: aaron.ballman, alexfh, hokein, njames93

Subscribers: xazax.hun, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78139

15 months ago[Fixed Point] Move the compassign LHS type correction a bit further down. NFCI.
Bevin Hansson [Thu, 16 Apr 2020 13:02:41 +0000 (15:02 +0200)]
[Fixed Point] Move the compassign LHS type correction a bit further down. NFCI.

Summary:
We can simplify the LHSTy correction for
fixed-point compassign by moving it below
the point where we know we have a compound
assignment.

Also, we shouldn't look at the LHS and RHS
separately; look at the computation result
type instead.

Looking at the LHS and RHS is also wrong
for compassigns with fixed and floating
point (though this does not work upstream
yet).

Reviewers: leonardchan

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78294

15 months ago[profile] Avoid duplicating or leaking VMO
Petr Hosek [Sat, 28 Mar 2020 00:48:28 +0000 (17:48 -0700)]
[profile] Avoid duplicating or leaking VMO

Now that write data continously into the memory mapping, we don't need
to keep the VMO handle around after it has been mapped. This change also
ensures that the VMO is always closed on error.

Differential Revision: https://reviews.llvm.org/D76963

15 months ago[ARM][MVE] Add VHADD and VHSUB patterns
Sam Parker [Wed, 15 Apr 2020 08:57:13 +0000 (09:57 +0100)]
[ARM][MVE] Add VHADD and VHSUB patterns

Add patterns that use a normal, non-wrapping, add and sub nodes along
with an arm vshr imm node.

Differential Revision: https://reviews.llvm.org/D77065

15 months agoFix opt-viewer tests failing after move from cgi.escape to html.escape
James Nagurne [Fri, 17 Apr 2020 06:01:01 +0000 (08:01 +0200)]
Fix opt-viewer tests failing after move from cgi.escape to html.escape

These two tests utilize pre-generated opt-viewer output to diff against
a run of opt-viewer over a known yaml file.

In commit 4b428e8f (D76126), the escape function used for rendering was changed
from cgi.escape to html.escape. This modification causes a behavioral
difference with regards to quote characters.

cgi will not escape quotes by default, but html will.

Therefore, these tests were failing because they expected the old behavior
of "string", but was instead seeing &quot;string&quot.

This solution modifies the known test outputs to use the escaped quotes
rather than not escaping quotes during rendering for no particular reason.

It is notable that when testing the optimization records generated by
LLVM, there was never quotes in the remarks I could find, specifically in
the Callee field where they exist in the pre-generated yaml for testing.

Differential Revision: https://reviews.llvm.org/D78241

15 months agoTemporaily revert [X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitt...
Shengchen Kan [Fri, 17 Apr 2020 06:11:05 +0000 (14:11 +0800)]
Temporaily revert [X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitter(Part II)

It causes some encoding fails. Plan to recommit it after fixing that.

This reverts commit 3017580c7961397f96e9481abf82bbf874bb2633.

15 months ago[X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitter(Part II)
Shengchen Kan [Fri, 17 Apr 2020 03:17:38 +0000 (11:17 +0800)]
[X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitter(Part II)

Summary:
We determine the REX prefix used by instruction in `determineREXPrefix`,
and this value is used in `emitMemModRMByte' and used as the return
value of `emitOpcodePrefix`.

Before this patch, REX was passed as reference to `emitPrefixImpl`, it
is strange and not necessary, e.g, we have to write
```
bool Rex = false;
emitPrefixImpl(CurOp, CurByte, Rex, MI, STI, OS);
```
in `emitPrefix` even if `Rex` will not be used.

So we let HasREX be the return value of `emitPrefixImpl`. The HasREX is passed
from `emitREXPrefix` to  `emitOpcodePrefix` and then to
`emitPrefixImpl`. This makes sense since REX is a kind of opcode prefix
and of course is a prefix.

Reviewers: craig.topper, pengfei

Reviewed By: craig.topper

Subscribers: annita.zhang, craig.topper, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78276

15 months ago[PowerPC] Exploit the rldicl + rldicl when and with mask
QingShan Zhang [Fri, 17 Apr 2020 05:24:00 +0000 (05:24 +0000)]
[PowerPC] Exploit the rldicl + rldicl when and with mask

If we are and the constant like 0xFFFFFFC00000, for now, we are using several
instructions to generate this 48bit constant and final an "and". However, we
could exploit it with two rotate instructions.

       MB          ME               MB+63-ME
+----------------------+     +----------------------+
|0000001111111111111000| ->  |0000000001111111111111|
+----------------------+     +----------------------+
 0                    63      0                    63
Rotate left ME + 1 bit first, and then, mask it with (MB + 63 - ME, 63),
finally, rotate back. Notice that, we need to round it with 64 bit for the
wrapping case.

Reviewed by: ChenZheng, Nemanjai

Differential Revision: https://reviews.llvm.org/D71831

15 months ago[SampleProfile] Use CallBase in function arguments and data structures to reduce...
Craig Topper [Fri, 17 Apr 2020 04:03:39 +0000 (21:03 -0700)]
[SampleProfile] Use CallBase in function arguments and data structures to reduce the number of explicit casts. NFCI

Removing CallSite left us with a bunch of explicit casts from
Instruction to CallBase. This moves the casts earlier so that
function arguments and data structure types are CallBase so
we don't have to cast when we use them.

Differential Revision: https://reviews.llvm.org/D78246

15 months ago[llvm-objcopy][MachO] Correctly identify object file endianness.
Lang Hames [Fri, 17 Apr 2020 04:48:40 +0000 (21:48 -0700)]
[llvm-objcopy][MachO] Correctly identify object file endianness.

The header magic value is held in the native endianness, so the method used in
cc0ec3fdb9d. Use MachOReader / MachOWriter's existing endianness tests instead.

15 months ago[mlir] [VectorOps] Progressive lowering of vector.broadcast
aartbik [Thu, 16 Apr 2020 23:01:42 +0000 (16:01 -0700)]
[mlir] [VectorOps] Progressive lowering of vector.broadcast

Summary:
Rather than having a full, recursive, lowering of vector.broadcast
to LLVM IR, it is much more elegant to have a progressive lowering
of each vector.broadcast into a lower dimensional vector.broadcast,
until only elementary vector operations remain. This results
in more elegant, step-wise code, that is easier to understand.
Also makes some optimizations in the generated code.

Reviewers: nicolasvasilache, mehdi_amini, andydavis1, grosul1

Reviewed By: nicolasvasilache

Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78071

15 months ago[llvm-objcopy][MachO] Fix MachO::relocation_info use after 386f1c114d5.
Lang Hames [Fri, 17 Apr 2020 01:21:41 +0000 (18:21 -0700)]
[llvm-objcopy][MachO] Fix MachO::relocation_info use after 386f1c114d5.

Use shift/mask operations to access r_symbolnum rather than relying on
MachO::relocation_info. This should fix the big-endian bot failures that were
caused by 386f1c114d5.

15 months ago[WebAssembly] Fix faulty logic in verifyRelocTargets
Wouter van Oortmerssen [Fri, 17 Apr 2020 01:19:29 +0000 (18:19 -0700)]
[WebAssembly] Fix faulty logic in verifyRelocTargets

15 months ago[gn build] Port 953a814aae4
LLVM GN Syncbot [Fri, 17 Apr 2020 00:58:15 +0000 (00:58 +0000)]
[gn build] Port 953a814aae4

15 months agoRemove the llvm/Support/StringPool.h file and related support now that it has no...
Chris Lattner [Thu, 16 Apr 2020 23:27:31 +0000 (16:27 -0700)]
Remove the llvm/Support/StringPool.h file and related support now that it has no clients.  A plain old StringSet<> is a better replacement.

Subscribers: mgorny, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78336

15 months agoRevert "[lldb/Utility] Provide a stringify_append overload for function pointers."
Jonas Devlieghere [Fri, 17 Apr 2020 00:50:56 +0000 (17:50 -0700)]
Revert "[lldb/Utility] Provide a stringify_append overload for function pointers."

Temporarily reverts commit d10386e1779599d217b5b849a079f29dfbe17024
because it breaks the Windows build. MSVC complains about an ambiguous
call to an overloaded function.

15 months ago[SelectionDAGBuilder][CGP][X86] Move some of SDB's gather/scatter uniform base handli...
Craig Topper [Fri, 17 Apr 2020 00:03:16 +0000 (17:03 -0700)]
[SelectionDAGBuilder][CGP][X86] Move some of SDB's gather/scatter uniform base handling to CGP.

I've always found the "findValue" a little odd and
inconsistent with other things in SDB.

This simplfifies the code in SDB to just handle a splat constant
address or a 2 operand GEP in the same BB. This removes the
need for "findValue" since the operands to the GEP are
guaranteed to be available. The splat constant handling is
new, but was needed to avoid regressions due to constant
folding combining GEPs created in CGP.

CGP is now responsible for canonicalizing gather/scatters into
this form. The pattern I'm using for scalarizing, a scalar GEP
followed by a GEP with an all zeroes index, seems to be subject
to constant folding that the insertelement+shufflevector was not.

Differential Revision: https://reviews.llvm.org/D76947

15 months ago[libc] Add cmake target for linting libc.
Paula Toth [Fri, 17 Apr 2020 00:40:36 +0000 (17:40 -0700)]
[libc] Add cmake target for linting libc.

Summary:
This patch implements running linting on llvm-libc using build rule targets.

1) adds a new target per entrypoint for linting with the naming convention `<qualified_target_name>.__lint__` e.g `libc.src.string.strlen.__lint__`.
2) makes the build target for each entrypoint depend on the linting targets so that they run along with compilation of each entrypoint.
3) adds a lint all target named `lint-libc`.  `check-libc` now depends on this new target.
4) linting creates a lot of additional targets from clang and clang-tidy that need to be built so an opt out flag can be passed to cmake: `LLVM_LIBC_ENABLE_LINTING`.

Reviewers: sivachandra, abrachet

Reviewed By: sivachandra

Subscribers: abrachet, mgorny, tschuett, libc-commits

Tags: #libc-project

Differential Revision: https://reviews.llvm.org/D77861

15 months ago[ubsan] Link shared runtime library with a version script.
Evgenii Stepanov [Thu, 16 Apr 2020 20:12:54 +0000 (13:12 -0700)]
[ubsan] Link shared runtime library with a version script.

Summary:
Do not reexport libgcc.a symbols and random sanitizer internal symbols
by applying a version script to the shared library build.

This fixes unwinder conflicts on Android that are created by reexporting
the unwinder interface from libgcc_real.a. The same is already done in
asan and hwasan.

Reviewers: vitalybuka, srhines

Subscribers: mgorny, #sanitizers, llvm-commits

Tags: #sanitizers

Differential Revision: https://reviews.llvm.org/D78325

15 months ago[NFC] Introduce a `LateInitialize()` method to `SymbolizerTool` that is called during...
Dan Liew [Wed, 15 Apr 2020 04:49:50 +0000 (21:49 -0700)]
[NFC] Introduce a `LateInitialize()` method to `SymbolizerTool` that is called during the LateInitialize stage of the sanitizer runtimes.

Summary:
This is implemented by adding a `Symbolizer::LateInitializeTools()`
method that iterates over the registered tools and calls the
`LateInitialize()` method on them.

`Symbolizer::LateInitializeTools()` is now called from the various
`Symbolizer::LateInitialize()` implementations.

The default implementation of `SymbolizerTool::LateInitialize()`
does nothing so this change should be NFC.

This change allows `SymbolizerTool` implementations to perform
any initialization that they need to perform at the
LateInitialize stage of a sanitizer runtime init.

rdar://problem/58789439

Reviewers: kubamracek, yln, vitalybuka, cryptoad, phosek, rnk

Subscribers: #sanitizers, llvm-commits

Tags: #sanitizers

Differential Revision: https://reviews.llvm.org/D78178

15 months ago[WebAssembly] Fix WasmEmitter link error.
Wouter van Oortmerssen [Fri, 17 Apr 2020 00:22:38 +0000 (17:22 -0700)]
[WebAssembly] Fix WasmEmitter link error.

15 months ago[NFC, tsan] Update tsan tests expectation
Pratyai Mazumder [Tue, 14 Apr 2020 23:13:25 +0000 (16:13 -0700)]
[NFC, tsan] Update tsan tests expectation

Summary:
These tests pass with clang, but fail if gcc was used.
gcc build creates similar but not the same stacks.

Reviewers: vitalybuka

Reviewed By: vitalybuka

Subscribers: dvyukov, llvm-commits, #sanitizers

Tags: #sanitizers

Differential Revision: https://reviews.llvm.org/D78114

15 months ago[WebAssembly] fixed target index strings in DebugInfo test
Wouter van Oortmerssen [Fri, 17 Apr 2020 00:11:14 +0000 (17:11 -0700)]
[WebAssembly] fixed target index strings in DebugInfo test

15 months ago[WebAssembly] Add int32 DW_OP_WASM_location variant
Wouter van Oortmerssen [Fri, 20 Mar 2020 02:53:51 +0000 (19:53 -0700)]
[WebAssembly] Add int32 DW_OP_WASM_location variant

This to allow us to add reloctable global indices as a symbol.
Also adds R_WASM_GLOBAL_INDEX_I32 relocation type to support it.

See discussion in https://github.com/WebAssembly/debugging/issues/12

15 months ago[CallSite removal][IPO] Change implementation of AbstractCallSite to store a CallBase...
Craig Topper [Thu, 16 Apr 2020 23:23:03 +0000 (16:23 -0700)]
[CallSite removal][IPO] Change implementation of AbstractCallSite to store a CallBase* instead of CallSite. NFCI.

CallSite will likely be removed soon, but AbstractCallSite serves a different purpose and won't be going away.

This patch switches it to internally store a CallBase* instead of a
CallSite. The only interface changes are the removal of the getCallSite
method and getCallBackUses now takes a CallBase&. These methods had only
a few callers that were easy enough to update without needing a
compatibility shim.

In the future once the other CallSites are gone, the CallSite.h
header should be renamed to AbstractCallSite.h

Differential Revision: https://reviews.llvm.org/D78322

15 months ago[Object] Remove conditional layout of bitfields in MachO::relocation_info.
Lang Hames [Thu, 16 Apr 2020 22:53:00 +0000 (15:53 -0700)]
[Object] Remove conditional layout of bitfields in MachO::relocation_info.

This removes the conditional layout of relocation_info bitfields that was
introduced in 3ccd677bf (svn r358839). The platform relocation_info
struct (defined in usr/include/mach-o/reloc.h) does not define the layout of
this struct differently on big-endian platforms and we want to keep the LLVM
and platform definitions in sync.

To fix the bug that 3ccd677bf addressed this patch modifies JITLink to construct
its relocation_info structs from the raw relocation words using shift and mask
operations.

15 months agollvm-addr2line: assume addresses on the command line are hexadecimal rather than...
Richard Smith [Fri, 24 Jan 2020 00:25:30 +0000 (16:25 -0800)]
llvm-addr2line: assume addresses on the command line are hexadecimal rather than attempting to guess the base based on the form of the number.

Summary:
This matches the behavior of GNU addr2line. We previously treated
hexadecimal addresses as binary if they started with 0b, otherwise as
octal if they started with 0, otherwise as decimal.

This only affects llvm-addr2line; the behavior of llvm-symbolize is
unaffected.

Reviewers: ikudrin, rupprecht, jhenderson

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73306

15 months ago[UBSan] Fix vptr checks on arm64e
Julian Lettner [Tue, 14 Apr 2020 19:48:58 +0000 (12:48 -0700)]
[UBSan] Fix vptr checks on arm64e

Fix UBSan's vptr checks in the presence of arm64e pointer signing.

Radar-Id: rdar://61786404

Reviewed By: vsk

Differential Revision: https://reviews.llvm.org/D78230

15 months ago[clangd] Remove unused and underused helpers. NFC
Sam McCall [Thu, 16 Apr 2020 23:08:32 +0000 (01:08 +0200)]
[clangd] Remove unused and underused helpers. NFC

15 months ago[clangd] Print PID on windows too
Sam McCall [Thu, 16 Apr 2020 23:00:42 +0000 (01:00 +0200)]
[clangd] Print PID on windows too

15 months ago[MLIR][cmake] Use DEPENDS instead of add_dependencies()
Stephen Neuendorffer [Thu, 16 Apr 2020 19:27:16 +0000 (12:27 -0700)]
[MLIR][cmake] Use DEPENDS instead of add_dependencies()

add_llvm_library() sometimes needs access to the dependencies in order to
generate new targets.  Using DEPENDS allows this.

Differential Revision: https://reviews.llvm.org/D78321

15 months ago[clang] Fix invalid comparator in tablegen
Eric Fiselier [Thu, 16 Apr 2020 22:35:31 +0000 (18:35 -0400)]
[clang] Fix invalid comparator in tablegen

Summary: The current version of the comparator does not introduce a strict weak ordering.

Reviewers: fowles, bkramer, sdesmalen

Reviewed By: sdesmalen

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78323

15 months ago[DWARF] Rename a function and comment it for clarity.
Davide Italiano [Thu, 16 Apr 2020 22:36:43 +0000 (15:36 -0700)]
[DWARF] Rename a function and comment it for clarity.

Pointed out by Adrian.

15 months ago[lldb/Utility] Provide a stringify_append overload for function pointers.
Jonas Devlieghere [Thu, 16 Apr 2020 22:28:42 +0000 (15:28 -0700)]
[lldb/Utility] Provide a stringify_append overload for function pointers.

Converting a function pointer to an object pointer is illegal as nothing
requires it to be in the same address space. Add an overload for
function pointers so we don't convert do this illegal conversion, and
simply print out "function pointer".

15 months agoRemove attach-failed-due-to-SIP checks which were not working
Jason Molenda [Thu, 16 Apr 2020 22:22:14 +0000 (15:22 -0700)]
Remove attach-failed-due-to-SIP checks which were not working

The SIP debugserver was calling in attach_failed_due_to_sip
haven't worked for a while; remove them.  To check this
properly we'd need debugsever to call out to codesign(1) to
inspect the entitlements, or the equivalant API,
and I'm not interested in adding that at this point.  SIP
is has been the default on macOS for a couple of releases
and it's expected behavior now.

<rdar://problem/59198052>

15 months ago[mlir][Linalg] NFC - Split out EDSCs that require a Folder
Nicolas Vasilache [Thu, 16 Apr 2020 21:24:48 +0000 (17:24 -0400)]
[mlir][Linalg] NFC - Split out EDSCs that require a Folder

Summary: This is an NFC cleanup in preparation for end-to-end named Linalg ops.

Differential Revision: https://reviews.llvm.org/D78331

15 months ago[WPD] Avoid noalias assumptions in unique return value optimization
Bob Haarman [Fri, 3 Apr 2020 06:26:04 +0000 (23:26 -0700)]
[WPD] Avoid noalias assumptions in unique return value optimization

Summary:
Changes the type of the @__typeid_.*_unique_member imports we generate
for unique return value optimization from i8 to [0 x i8]. This
prevents assuming that these imports do not alias, such as when
two unique return values occur in the same vtable.

Fixes PR45393.

Reviewers: tejohnson, pcc

Reviewed By: pcc

Subscribers: aganea, hiraditya, rnk, george.burgess.iv, dblaikie, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77421

15 months ago[MLIR][cmake] Remove redundant add_dependencies()
Stephen Neuendorffer [Thu, 16 Apr 2020 18:52:05 +0000 (11:52 -0700)]
[MLIR][cmake] Remove redundant add_dependencies()

Libraries declared as target_link_libraries() do not also need
to be declared as dependencies using add_dependencies().

Differential Revision: https://reviews.llvm.org/D78320

15 months ago[SCCP] Add widening test case.
Florian Hahn [Sat, 11 Apr 2020 20:47:48 +0000 (21:47 +0100)]
[SCCP] Add widening test case.

15 months agoExpose ATOMIC in the clang python bindings
Benjamin Kramer [Thu, 16 Apr 2020 21:35:38 +0000 (23:35 +0200)]
Expose ATOMIC in the clang python bindings

Following 38ca7b11db2d22e0fdfbff3f19276f9796f747d3

15 months ago[mlir] ODS: support operations with resizable operand lists
Alex Zinenko [Thu, 16 Apr 2020 21:24:58 +0000 (23:24 +0200)]
[mlir] ODS: support operations with resizable operand lists

MLIR supports operations with resizable operand lists, but this property must
be indicated during the construction of such operations. It can be done
programmatically by calling a function on OperationState. Introduce an
ODS-internal trait `ResizableOperandList` to indicate such operations are use
it when generating the bodies of various `build` functions as well as the
`parse` function when the declarative assembly format is used.

Differential Revision: https://reviews.llvm.org/D78292

15 months ago[libc++] Move handling of convenience substitutions outside of config.py
Louis Dionne [Thu, 16 Apr 2020 20:17:14 +0000 (16:17 -0400)]
[libc++] Move handling of convenience substitutions outside of config.py

These substitutions are strongly tied to the operation of the test
format, so it makes sense to have them defined by the test format
instead of the Lit configuration. They should be defined regardless
of which configuration is in use.

15 months ago[x86] auto-generate complete test checks; NFC
Sanjay Patel [Thu, 16 Apr 2020 21:16:22 +0000 (17:16 -0400)]
[x86] auto-generate complete test checks; NFC

15 months ago[ARM] MVE postinc tests. NFC
David Green [Tue, 14 Apr 2020 17:49:15 +0000 (18:49 +0100)]
[ARM] MVE postinc tests. NFC

15 months ago[lldb/Utility] Fix a bug in stringify_append for printing addresses.
Jonas Devlieghere [Thu, 16 Apr 2020 21:02:05 +0000 (14:02 -0700)]
[lldb/Utility] Fix a bug in stringify_append for printing addresses.

The recent change in the API macros revealed that we were not printing
the pointer address for a bunch of methods, but rather the address of
the pointer. It's something I had already noticed while looking at some
reproducer traces, but hadn't made it to the top of my list yet. This
fixes the issue by providing a more specific overload.

15 months agotsan: fixes to ThreadClock::releaseStoreAcquire and tests
Daniel S Fava [Thu, 16 Apr 2020 20:53:26 +0000 (22:53 +0200)]
tsan: fixes to ThreadClock::releaseStoreAcquire and tests

Fixes:
1. Setting the number of entries in a thread's clock to max between
   the thread and the SyncClock the thread is acquiring from
2. Setting last_acquire_

Unit- and stress-test for releaseStoreAcquire added to
tests/unit/tsan_clock_test.cpp

15 months ago[MLIR] Complete refactoring of Affine dialect into sub-libraries.
Stephen Neuendorffer [Thu, 16 Apr 2020 18:11:13 +0000 (11:11 -0700)]
[MLIR] Complete refactoring of Affine dialect into sub-libraries.

There were some unused CMakeFiles for Affine/IR and Affine/EDSC.
This change builds separate MLIRAffineOps and MLIRAffineEDSC libraries
using those CMakeFiles.  This combination replaces the old MLIRAffine
library.

Differential Revision: https://reviews.llvm.org/D78317

15 months ago[DWARF] Add instructions to regenerate this test, if needed.
Davide Italiano [Thu, 16 Apr 2020 20:31:32 +0000 (13:31 -0700)]
[DWARF] Add instructions to regenerate this test, if needed.

15 months ago[Shell] Remove incorrectly cargo-culted UNSUPPORTED.
Davide Italiano [Thu, 16 Apr 2020 20:22:06 +0000 (13:22 -0700)]
[Shell] Remove incorrectly cargo-culted UNSUPPORTED.

Let's see if this sticks on the bots.

15 months ago[ARM] Mir test for machine sinking multiple def instructions. NFC
David Green [Thu, 16 Apr 2020 19:53:32 +0000 (20:53 +0100)]
[ARM] Mir test for machine sinking multiple def instructions. NFC

15 months ago[clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.
Chris Lattner [Thu, 16 Apr 2020 05:27:19 +0000 (22:27 -0700)]
[clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet.

Summary:
PreprocessorTracker is the last user of the old StringPool class, which
isn't super loved and isn't a great improvement over a plan StringSet.
Once this goes in we can remove StringPool entirely.

This is as discussed on cfe-dev.

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78273

15 months agoReland: Don't expose unavailable cstdio functions.
Dan Albert [Thu, 12 Mar 2020 18:16:30 +0000 (11:16 -0700)]
Reland: Don't expose unavailable cstdio functions.

Marked unsupported for C++03 and C++11 since this test uses alias
declarations, and at least one C++03 bot was failing with
-Wc++11-extensions.

Change-Id: I8c3a579edd7eb83e0bc74e85d116b68f22400161

15 months ago[FileCheck] Fix --dump-input annotation sort per input line
Joel E. Denny [Thu, 16 Apr 2020 18:53:56 +0000 (14:53 -0400)]
[FileCheck] Fix --dump-input annotation sort per input line

Without this patch, `--dump-input` annotations on a single input line
are sorted by the associated directive's check-file line.  That seemed
fine because that's often identical to the order in which FileCheck
looks for matches for those directives.

The first problem is that an `--implicit-check-not` pattern has no
check-file line.  The logical equivalent is sorting in command-line
order, but that's not implemented.

The second problem is that, unlike a directive, an
`--implicit-check-not` pattern applies at many points, between many
different pairs of directives.  However, sorting in command-line order
gathers all its associated diagnostics together at one point in an
input line's list of annotations.

In general, it seems to be easier to understand FileCheck's logic when
annotations on a single input line are sorted in the order FileCheck
produced the associated diagnostics, so this patch makes that change.
As documented in the patch, the annotation sort order is also
especially relevant to `CHECK-LABEL`, `CHECK-NOT`, and `CHECK-DAG`, so
this patch updates or extends tests to check the sort makes sense for
them.  (However, the sort for `CHECK-DAG` annotations should not
actually be altered by this patch.)

Reviewed By: thopre

Differential Revision: https://reviews.llvm.org/D77607